Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TokenVerifier to verify authorization too #4061

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Aug 15, 2024

Fixes #4042

Proposed Changes

  • Update TokenVerifier to verify authorization too

Release Note

Verify Authorization on Ingress too

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2024
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi August 15, 2024 10:14
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.48%. Comparing base (ba49d0f) to head (6a54c86).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
- Coverage   48.49%   48.48%   -0.02%     
==========================================
  Files         244      244              
  Lines       14712    14712              
==========================================
- Hits         7135     7133       -2     
- Misses       6866     6867       +1     
- Partials      711      712       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2024
@creydr creydr force-pushed the update-tokenverifier-to-verify-authz-too branch from 8cb9ae0 to 99e5dcc Compare August 22, 2024 05:58
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
@creydr creydr force-pushed the update-tokenverifier-to-verify-authz-too branch from 99e5dcc to 6a54c86 Compare August 22, 2024 06:07
@creydr creydr changed the title [WIP] Update TokenVerifier to verify authorization too Update TokenVerifier to verify authorization too Aug 22, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2024
@creydr
Copy link
Contributor Author

creydr commented Aug 22, 2024

magic.go:135: failed to wait for resources to be deleted: timed out waiting for the condition
--- FAIL: TestChannelChain (149.87s)

Seems to be a flake

/test reconciler-tests

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fc37e5d into knative-extensions:main Aug 22, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data-plane] Update TokenVerifier to check for the allowed subjects too
3 participants