Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code of conduct #1

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Add code of conduct #1

merged 1 commit into from
Jun 25, 2020

Conversation

evankanderson
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2020
@evankanderson
Copy link
Contributor Author

/hold

This is to verify Prow is set up correctly (knative/test-infra#2222)

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@evankanderson
Copy link
Contributor Author

/retest

1 similar comment
@evankanderson
Copy link
Contributor Author

/retest

@evankanderson
Copy link
Contributor Author

/hold cancel

I'll add test files to make things happy

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@pierDipi
Copy link
Member

I'll add test files to make things happy

I did this for you here: #4

@slinkydeveloper
Copy link
Contributor

Can you rebase on master?

matzew
matzew approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented Jun 25, 2020

/test all

@matzew
Copy link
Contributor

matzew commented Jun 25, 2020

/refresh

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jun 25, 2020 •
edited
Loading

@evankanderson: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-sandbox-eventing-kafka-broker-go-coverage 2311bc0 link /test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot merged commit dcb1e4a into knative-extensions:master Jun 25, 2020
@aliok aliok mentioned this pull request Jan 11, 2022
Merged
mgencur referenced this pull request in mgencur/eventing-kafka-broker Feb 7, 2022
@matzew
Merge pull request #1 from matzew/prepare_ocp_prow
f320ca6 
Prepare ocp prow
yijie-04 pushed a commit to yijie-04/eventing-kafka-broker that referenced this pull request Apr 2, 2024
@karkabbage
Merge pull request knative-extensions#1 from yijie-04/main
67b9c9a 
added label selector
@pierDipi pierDipi mentioned this pull request Sep 24, 2024
Merged
knative-prow bot pushed a commit that referenced this pull request Sep 24, 2024
@pierDipi
Report error for unsupported PKCS #1 format for the private key (#4114)
f9f799c 
Java Kafka clients don't support PKCS #1 format for private keys.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Sep 27, 2024
@knative-prow-robot @pierDipi
Report error for unsupported PKCS #1 format for the private key (#4116)
755c8bb 
Java Kafka clients don't support PKCS #1 format for private keys.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Sep 27, 2024
@knative-prow-robot @pierDipi
Report error for unsupported PKCS #1 format for the private key (#4117)
ea10ce6 
Java Kafka clients don't support PKCS #1 format for private keys.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
maschmid pushed a commit to maschmid/eventing-kafka-broker that referenced this pull request Oct 8, 2024
@pierDipi
Report error for unsupported PKCS knative-extensions#1 format for the…
4cc583f 
… private key (knative-extensions#1280)

Java Kafka clients don't support PKCS knative-extensions#1 format for private keys.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
maschmid pushed a commit to maschmid/eventing-kafka-broker that referenced this pull request Oct 25, 2024
@pierDipi
Report error for unsupported PKCS knative-extensions#1 format for the…
f786a9c 
… private key (knative-extensions#1281)

Java Kafka clients don't support PKCS knative-extensions#1 format for private keys.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evankanderson @pierDipi @slinkydeveloper @knative-prow-robot @matzew @googlebot