Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventing-kafka-broker prow jobs #2222

Merged

Conversation

evankanderson
Copy link
Member

What this PR does, why we need it:

Set up knative-sandbox/eventing-kafka-broker.

Which issue(s) this PR fixes:

Related: knative/community#143

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2020
@evankanderson
Copy link
Member Author

It looks like some part of the generation script needs to be length aware:

name of Periodic job "ci-knative-sandbox-eventing-kafka-broker-continuous-beta-prow-tests" too long (should be at most 63 characters)
name of Periodic job "ci-knative-sandbox-eventing-kafka-broker-go-coverage-beta-prow-tests" too long (should be at most 63 characters)

Length is 67 and 68 characters, respectively.

@pierDipi
Copy link
Member

It looks like some part of the generation script needs to be length aware:

name of Periodic job "ci-knative-sandbox-eventing-kafka-broker-continuous-beta-prow-tests" too long (should be at most 63 characters)
name of Periodic job "ci-knative-sandbox-eventing-kafka-broker-go-coverage-beta-prow-tests" too long (should be at most 63 characters)

Length is 67 and 68 characters, respectively.

Can we replace prow-tests with pt for shortening the name?


We will have some non Go code (Java), do we need any kind of configurations for that?

@evankanderson
Copy link
Member Author

/retest

@chaodaiG
Copy link
Contributor

/retest

It's blocked by my changes from #2218 , let me see if I can fix it in 10 minutes, otherwise I'll roll back

@chaodaiG
Copy link
Contributor

/retest

It's blocked by my changes from #2218 , let me see if I can fix it in 10 minutes, otherwise I'll roll back

Should be fixed by #2227

@evankanderson
Copy link
Member Author

/retest

@chaodaiG
Copy link
Contributor

/retest

Fixing one last error, I'll retest for you once it's merged

@evankanderson
Copy link
Member Author

/retest

@evankanderson
Copy link
Member Author

Hey, tests pass!

@evankanderson
Copy link
Member Author

This is ready!

@evankanderson
Copy link
Member Author

/assign @chaodaiG

@chaodaiG
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@chaodaiG
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot knative-prow-robot merged commit 514129c into knative:master Jun 22, 2020
@knative-prow-robot
Copy link
Collaborator

@evankanderson: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/prod/prow/jobs/config.yaml

In response to this:

What this PR does, why we need it:

Set up knative-sandbox/eventing-kafka-broker.

Which issue(s) this PR fixes:

Related: knative/community#143

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants