-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventing-kafka-broker prow jobs #2222
Add eventing-kafka-broker prow jobs #2222
Conversation
It looks like some part of the generation script needs to be length aware:
Length is 67 and 68 characters, respectively. |
Can we replace We will have some non Go code (Java), do we need any kind of configurations for that? |
/retest |
It's blocked by my changes from #2218 , let me see if I can fix it in 10 minutes, otherwise I'll roll back |
/retest |
Fixing one last error, I'll retest for you once it's merged |
/retest |
Hey, tests pass! |
This is ready! |
/assign @chaodaiG |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@evankanderson: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does, why we need it:
Set up
knative-sandbox/eventing-kafka-broker
.Which issue(s) this PR fixes:
Related: knative/community#143