Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[Backport] fix label consistency #244

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 1, 2020

Backport of #242

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 1, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2020
@knative-prow-robot
Copy link
Contributor

Hi @skonto. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-0.19@3844a7e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.19     #244   +/-   ##
===============================================
  Coverage                ?   75.95%           
===============================================
  Files                   ?      112           
  Lines                   ?     4258           
  Branches                ?        0           
===============================================
  Hits                    ?     3234           
  Misses                  ?      829           
  Partials                ?      195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3844a7e...cc6102f. Read the comment docs.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@knative-prow-robot knative-prow-robot merged commit a413410 into knative-extensions:release-0.19 Dec 1, 2020
matzew pushed a commit to matzew/eventing-kafka that referenced this pull request Dec 9, 2020
matzew pushed a commit to matzew/eventing-kafka that referenced this pull request Jul 1, 2021
…ive-extensions#244)

* [QE] Continual tests for KafkaSource for upgrade testing

Backport of (knative#563)

* Using knative/eventing#4815 to override wathola sender transport
* Actual way of replacing an image used for wathola sender
* Reformatting
* Wathola Kafka Sender utilizing plain connection
* Implementing SUT and custom sender
* KafkaSource upgrade test
* Update knative-eventing to 8270497041f2
* Using source config template
* Export kafkaTopicEndpoint to be able to read on TOML
* wathola config reader can read both string and map[string]interface{} for sender.address
* KafkaSource upgrade test works
* Allow to influence Kafka cluster connection details
* Channel tests working
* Removing unused variable name
* Review knative/eventing#5321 changes
* Updates after review of knative/eventing#4815
* Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit
* Update deps
* Update deps
* Refactor after review
* Shorten the TypeMeta field
* Tweak the merge slices func after review

* Add wathola-kafka-sender test image

* update pkg

* Revert "update deps"

* Remove the interim personal fork
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants