Skip to content

Commit

Permalink
fix label consistency (knative-extensions#244)
Browse files Browse the repository at this point in the history
  • Loading branch information
skonto authored and matzew committed Dec 9, 2020
1 parent 9607a32 commit e473bbf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/source/reconciler/source/resources/labels.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ const (
func GetLabels(name string) map[string]string {
return map[string]string{
"eventing.knative.dev/source": controllerAgentName,
"eventing.knative.dev/SourceName": name,
"eventing.knative.dev/sourceName": name,
}
}
2 changes: 1 addition & 1 deletion pkg/source/reconciler/source/resources/labels_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func TestGetLabels(t *testing.T) {

wantLabels := map[string]string{
"eventing.knative.dev/source": "kafka-source-controller",
"eventing.knative.dev/SourceName": "testSourceName",
"eventing.knative.dev/sourceName": "testSourceName",
}

eq := cmp.Equal(testLabels, wantLabels)
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/helpers/kafka_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ func CheckKafkaSourceState(ctx context.Context, c *testlib.Client, name string,
//On timeout reports error
func CheckRADeployment(ctx context.Context, c *testlib.Client, name string, inState func(deps *appsv1.DeploymentList) (bool, error)) error {
listOptions := metav1.ListOptions{
LabelSelector: fmt.Sprintf("%s=%s", "eventing.knative.dev/SourceName", name),
LabelSelector: fmt.Sprintf("%s=%s", "eventing.knative.dev/sourceName", name),
}
kDeps := c.Kube.AppsV1().Deployments(c.Namespace)
var lastState *appsv1.DeploymentList
Expand Down

0 comments on commit e473bbf

Please sign in to comment.