Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reusable-helper-go-style.yaml #179

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ReToCode
Copy link
Member

Context: Golang lint has some weird errors on Serving CI in version 1.52.0 with golang 1.21. Tested it locally with latest version without issues: knative/serving#14610 (comment)

Change

  • Bump golangci-lint to version 1.55.2

/assign @skonto
/assign @dprotaso
/assign @krsna-m

Copy link

knative-prow bot commented Nov 30, 2023

@ReToCode: GitHub didn't allow me to assign the following users: krsna-m.

Note that only knative members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Context: Golang lint has some weird errors on Serving CI in version 1.52.0 with golang 1.21. Tested it locally with latest version without issues: knative/serving#14610 (comment)

Change

  • Bump golangci-lint to version 1.55.2

/assign @skonto
/assign @dprotaso
/assign @krsna-m

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Nov 30, 2023

/lgtm

Copy link

knative-prow bot commented Nov 30, 2023

@krsna-m: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link
Contributor

krsna-m commented Nov 30, 2023

Sorry @ReToCode don't have permissions until knative/community#1470 merges

@krsna-m
Copy link
Contributor

krsna-m commented Nov 30, 2023

@upodroid or @cardil from productivity maybe can give it a 👍

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link

knative-prow bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a3f53e5 into knative:main Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants