Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter config to new schema #14691

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Dec 1, 2023

Context

golangci-lint now uses depguard V2 which has a totally different (and breaking) configuration syntax. References:

Proposed Changes

  • Update linter depguard config to new schema

/assign @skonto
/assign @dprotaso

Copy link

knative-prow bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74019af) 86.04% compared to head (74b94a1) 86.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14691      +/-   ##
==========================================
+ Coverage   86.04%   86.05%   +0.01%     
==========================================
  Files         197      197              
  Lines       14937    14937              
==========================================
+ Hits        12852    12854       +2     
+ Misses       1776     1774       -2     
  Partials      309      309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Dec 1, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@skonto
Copy link
Contributor

skonto commented Dec 1, 2023

Could we also update lint to be latest eg. 1.55.x?

@ReToCode
Copy link
Member Author

ReToCode commented Dec 1, 2023

Could we also update lint to be latest eg. 1.55.x?

Already done: knative/actions#179

@knative-prow knative-prow bot merged commit cd4e4f6 into knative:main Dec 1, 2023
51 checks passed
@dprotaso
Copy link
Member

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #14847

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants