-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linter config to new schema #14691
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14691 +/- ##
==========================================
+ Coverage 86.04% 86.05% +0.01%
==========================================
Files 197 197
Lines 14937 14937
==========================================
+ Hits 12852 12854 +2
+ Misses 1776 1774 -2
Partials 309 309 ☔ View full report in Codecov by Sentry. |
/lgtm |
Could we also update lint to be latest eg. 1.55.x? |
Already done: knative/actions#179 |
/cherry-pick release-1.12 |
@dprotaso: new pull request created: #14847 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Context
golangci-lint
now uses depguard V2 which has a totally different (and breaking) configuration syntax. References:Proposed Changes
/assign @skonto
/assign @dprotaso