WIP: Porting 4280 eventing upstream to KafkaChannel #1642
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/cc @vaikas mind looking? |
knative-prow-robot
requested review from
lionelvillard,
pierDipi,
slinkydeveloper and
vaikas
| @@ -115,7 +115,9 @@ func NewController(ctx context.Context, cmw configmap.Watcher) *controller.Impl | |||
| kafkachannelLister: kafkaChannelInformer.Lister(), | |||
| kafkachannelInformer: kafkaChannelInformer.Informer(), | |||
| } | |||
| r.impl = kafkachannelreconciler.NewImpl(ctx, r) | |||
| r.impl = kafkachannelreconciler.NewImpl(ctx, r, func(impl *controller.Impl) controller.Options { | |||
There was a problem hiding this comment.
I think this is not going to work because the reconciler updates the status here:
https://github.com/knative/eventing-contrib/blob/master/kafka/channel/pkg/reconciler/dispatcher/kafkachannel.go#L172
There was a problem hiding this comment.
Yeah, status updates need to be moved to the controller, see also knative-extensions/eventing-kafka#98.
There was a problem hiding this comment.
ah, yeah - let's do it on the new repo
There was a problem hiding this comment.
@matzew I think on the new repo the issue is the same. kafka ch dispatcher always updates that status
|
@matzew: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@matzew: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
Release Note
Docs