Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

WIP: Porting 4280 eventing upstream to KafkaChannel #1642

Closed
wants to merge 1 commit into from
Closed

WIP: Porting 4280 eventing upstream to KafkaChannel #1642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kafka/channel/pkg/reconciler/dispatcher/kafkachannel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ func NewController(ctx context.Context, cmw configmap.Watcher) *controller.Impl
kafkachannelLister: kafkaChannelInformer.Lister(),
kafkachannelInformer: kafkaChannelInformer.Informer(),
}
r.impl = kafkachannelreconciler.NewImpl(ctx, r)
r.impl = kafkachannelreconciler.NewImpl(ctx, r, func(impl *controller.Impl) controller.Options {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not going to work because the reconciler updates the status here:
https://github.com/knative/eventing-contrib/blob/master/kafka/channel/pkg/reconciler/dispatcher/kafkachannel.go#L172

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, status updates need to be moved to the controller, see also knative-extensions/eventing-kafka#98.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah - let's do it on the new repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew I think on the new repo the issue is the same. kafka ch dispatcher always updates that status

return controller.Options{SkipStatusUpdates: true}
})

logger.Info("Setting up event handlers")

Expand Down