fixing that triggers can actually have no filters... #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
the
approved
|
@matzew can you add at least a unit test for this? |
lberk
reviewed
Mar 4, 2020
| for k, v := range *source.Spec.Filter.Attributes { | ||
| sink.Spec.Filter.Attributes[k] = v | ||
| } | ||
| } | ||
| if source.Spec.Filter.DeprecatedSourceAndType != nil { | ||
| sink.Spec.Filter = &v1beta1.TriggerFilter{ | ||
| Attributes: make(v1beta1.TriggerFilterAttributes, 0), |
There was a problem hiding this comment.
could we not just make this slice at least two already given that we default to adding a source and type attribute?
vaikas
reviewed
Mar 4, 2020
| } | ||
| if source.Spec.Filter.Attributes != nil { | ||
| sink.Spec.Filter = &v1beta1.TriggerFilter{ | ||
| Attributes: make(v1beta1.TriggerFilterAttributes, 0), |
There was a problem hiding this comment.
instead of 0, how about?
len(source.Spec.Filter.Attributes)
knative-prow-robot
added
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2695 (and is a backport of 2696 to the
knative:release-0.13branch)Proposed Changes
TriggerFilter{}, and not requiring actual attributes in thereRelease Note
Docs