Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lberk to approvers #3165

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add lberk to approvers #3165

merged 1 commit into from
Sep 2, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented May 19, 2020 •
edited
Loading

Criteria from https://github.com/knative/community/blob/master/ROLES.md#approver

Reviewer of the codebase for at least 3 months:

First reviews:
[Eventing] #1601 July 30, 2019

Primary reviewer for at least 10 substantial PRs to the codebase [11].
#3924
#3954
#2759
#3447
#3964
#3313
#3226
#3224
#3070
#3050
#3016

Reviewed at least 30 PRs to the codebase [30]
eventing:
#3964
#3958
#3955
#3954
#3947
#3924
#3902
#3897
#3762
#3742
#3447
#3395
#3361
#3251
#3243
#3226
#3224
#3223
#3221
#3202
#3184
#3180
#3070
#3050
#3016
#3070
#2759
#2700
#2258
#1601

Nominated by an area lead with no objections from other leads:
@matzew

Proposals Authored & Submitted:
Eventing contrib vs Sandbox
knative github labels

I'm following the observed pattern of approver status across both
eventing and contrib repos, if that's not appropriate, I'd be happy to
take feedback accordingly!

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 19, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2020
@lberk lberk mentioned this pull request May 19, 2020
Merged
@lberk lberk force-pushed the lberk_approver branch from 2f2d32b to 1330419 Compare May 20, 2020 18:59
@grantr
Copy link
Contributor

grantr commented May 21, 2020

Thank you for all your contributions @lberk!

To gain root approver status, one must meet the review requirements with PRs in this repo alone ("the part of the codebase for which one would be an approver in an OWNERS file"). The eventing-contrib PRs strengthen the case, but they don't help meet the approver requirements.

I'll put this PR on hold for now. When you have enough reviews in this repo to meet the approver requirements, please update the PR body and unhold.

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2020
grantr
grantr reviewed Sep 1, 2020
View reviewed changes
OWNERS Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2020
@vaikas
Copy link
Contributor

vaikas commented Sep 1, 2020

+1 from me :)

@grantr
Copy link
Contributor

grantr commented Sep 1, 2020

/lgtm

Thanks for all your hard work @lberk! 😄

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@vaikas
Copy link
Contributor

vaikas commented Sep 1, 2020

/lgtm
@lionelvillard if you're good, please remove the hold & approve

@lionelvillard
Copy link
Member

/unhold
/approve

@lberk congrats!!! 🍾

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@knative-prow-robot knative-prow-robot merged commit 0568f72 into knative:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr left review comments

@Harwayne Harwayne Awaiting requested review from Harwayne

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@grantr grantr

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lberk @grantr @vaikas @lionelvillard @knative-prow-robot @googlebot