Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flows storage v1 #3924

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Flows storage v1 #3924

merged 1 commit into from
Aug 27, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 25, 2020 •
edited
Loading

Fixes #3581

Proposed Changes

  • Make flows.* v1 resources the stored version
  • Add those resources to migration job

Release Note


- 🧽 Update or clean up current behavior
Change storage versions of flows.* resources from v1beta1 to v1:
          - "parallels.flows.knative.dev"
          - "sequences.flows.knative.dev"

action required: You must run pre-install job prior to upgrading to get flows.* resources to v1 API.

Docs

No docs change necessary. The content at https://knative.dev/docs/install/upgrade-installation/#run-pre-install-tools-before-upgrade is good enough

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 25, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2020
@aliok aliok force-pushed the flows-storage-v1 branch from 1b961ff to a0e8e1f Compare August 27, 2020 10:08
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 27, 2020
@aliok aliok force-pushed the flows-storage-v1 branch from a0e8e1f to 0fc25a2 Compare August 27, 2020 10:53
@aliok aliok changed the title [WIP] Flows storage v1 Flows storage v1 Aug 27, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2020
@aliok
Copy link
Member Author

aliok commented Aug 27, 2020

cc @nlopezgi

@lionelvillard
Copy link
Member

/approve

@nlopezgi for LGTM

thanks!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@nlopezgi
Copy link
Contributor

/lgtm thanks!

@nlopezgi
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
lberk
lberk reviewed Aug 27, 2020
View reviewed changes
config/pre-install/v0.18.0/clusterrole.yaml
- "parallels"
- "sequences"
verbs:
- "get"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, it'd probably be good to alias these commonly used verbs together, but lets snag that in a follow up PR

@lberk
Copy link
Member

lberk commented Aug 27, 2020

/lgtm

@knative-prow-robot knative-prow-robot merged commit fca0af0 into knative:master Aug 27, 2020
@aliok aliok deleted the flows-storage-v1 branch August 27, 2020 17:56
@lberk lberk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@lberk lberk lberk left review comments

@Harwayne Harwayne Awaiting requested review from Harwayne

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@lberk lberk

@nlopezgi nlopezgi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make flows.* v1 resources the stored version
7 participants
@aliok @lionelvillard @knative-prow-robot @nlopezgi @lberk @mattmoor @googlebot