Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] Set transition time initially on sequence statuses #6653

Merged
merged 1 commit into from
Dec 21, 2022
Merged

[release-1.8] Set transition time initially on sequence statuses #6653

merged 1 commit into from
Dec 21, 2022

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #6647

@creydr @knative-prow-robot
Set transition time initially on sequence statuses
311c992 
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Dec 20, 2022
Merged
5 tasks
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2022
matzew
matzew approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited
Loading

Codecov Report

Base: 81.92% // Head: 81.89% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (311c992) compared to base (9212935).
Patch coverage: 58.82% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.8    #6653      +/-   ##
===============================================
- Coverage        81.92%   81.89%   -0.04%     
===============================================
  Files              235      235              
  Lines            11770    11783      +13     
===============================================
+ Hits              9643     9650       +7     
- Misses            1652     1658       +6     
  Partials           475      475
Impacted Files Coverage Δ
pkg/apis/flows/v1/sequence_lifecycle.go 86.79% <58.82%> (-4.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matzew
Copy link
Member

matzew commented Dec 21, 2022

/test upgrade-tests

@creydr
Copy link
Member

creydr commented Dec 21, 2022

/retest-required
/cherry-pick release-1.7

@knative-prow-robot
Copy link
Contributor Author

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/retest-required
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 3a47622 into knative:release-1.8 Dec 21, 2022
@knative-prow-robot knative-prow-robot mentioned this pull request Dec 21, 2022
Merged
@knative-prow-robot
Copy link
Contributor Author

@creydr: new pull request created: #6654

In response to this:

/retest-required
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow bot pushed a commit that referenced this pull request Dec 21, 2022
@knative-prow-robot @creydr
[release-1.7] Set transition time initially on sequence statuses (#6654)
96c9d32 
This is an automated cherry-pick of #6653

```release-note

```

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @matzew @creydr