Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.7] Set transition time initially on sequence statuses #6654

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #6653


Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@knative-prow knative-prow bot requested review from akashrv and lberk December 21, 2022 09:54
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2022
@creydr
Copy link
Member

creydr commented Dec 21, 2022

/assign @matzew @aliok
/cherry-pick release-1.6

@knative-prow-robot
Copy link
Contributor Author

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/assign @matzew @aliok
/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 81.99% // Head: 81.96% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (c4ef123) compared to base (057ee26).
Patch coverage: 58.82% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7    #6654      +/-   ##
===============================================
- Coverage        81.99%   81.96%   -0.04%     
===============================================
  Files              235      235              
  Lines            11751    11764      +13     
===============================================
+ Hits              9635     9642       +7     
- Misses            1646     1652       +6     
  Partials           470      470              
Impacted Files Coverage Δ
pkg/apis/flows/v1/sequence_lifecycle.go 86.79% <58.82%> (-4.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@knative-prow knative-prow bot merged commit 96c9d32 into knative:release-1.7 Dec 21, 2022
@knative-prow-robot
Copy link
Contributor Author

@creydr: new pull request created: #6657

In response to this:

/assign @matzew @aliok
/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants