add KnativeReference #1030
add KnativeReference #1030
Conversation
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
| APIVersion string `json:"apiVersion,omitempty"` | ||
| } | ||
|
|
||
| func (kr *KnativeReference) Validate(ctx context.Context) *apis.FieldError { |
There was a problem hiding this comment.
Can you also add a default and a method to inject the current object's namespace into the context? It can be a follow up
There was a problem hiding this comment.
I can add the method to inject it from an object, but I'm unclear what you think the default method should do?
|
/lgtm |
Introduce a KnativeReference resource to replace the existing uses of ObjectReference. Motivation for the change:
kubernetes/kubernetes#87459
And partly motivated by this as well:
knative/eventing#2470
I'll follow up with another PR to replace ObjectReference with this object. This should have no user visible changes, since the wire format is not changing.