Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning on ObjectReference #87459

Merged
merged 1 commit into from
Jan 24, 2020
Merged

add warning on ObjectReference #87459

merged 1 commit into from
Jan 24, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 22, 2020 •
edited
Loading

Clarify the thinking about ObjectReference in our API.

/kind cleanup
/priority important-soon

NONE

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 22, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

liggitt
liggitt reviewed Jan 22, 2020
View reviewed changes
staging/src/k8s.io/api/core/v1/types.go Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 22, 2020
@deads2k deads2k force-pushed the object-ref-warning branch 2 times, most recently from 2bcbc2d to f0f1dd3 Compare January 22, 2020 20:17
liggitt
liggitt reviewed Jan 22, 2020
View reviewed changes
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved
@deads2k deads2k force-pushed the object-ref-warning branch from d537d2b to 48c51ae Compare January 22, 2020 21:54
@deads2k deads2k force-pushed the object-ref-warning branch from 48c51ae to 90b49e8 Compare January 23, 2020 00:28
@deads2k
Copy link
Contributor Author

deads2k commented Jan 23, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jan 23, 2020

/sig api-machinery
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 5918208 into kubernetes:master Jan 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 24, 2020
@Miciah Miciah mentioned this pull request Jan 28, 2020
Closed
This was referenced Jan 31, 2020
Closed
Merged
@Miciah Miciah mentioned this pull request Apr 9, 2020
Closed
@enxebre enxebre mentioned this pull request Apr 13, 2020
Closed
@robscott robscott mentioned this pull request Sep 3, 2020
Closed
@Miciah Miciah mentioned this pull request Nov 29, 2021
Merged
@elevran elevran mentioned this pull request Dec 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @fejta-bot @liggitt @k8s-ci-robot