Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove certain annotations for germline mutations #94

Merged

Conversation

onursumer
Copy link
Collaborator

@onursumer onursumer commented Dec 28, 2020

Related to #78

Copy link
Collaborator

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if sorting annotation column is still useful in this case, probably better to disable it if we don't want to sort, or make it work properly (now if you sort annotation column, the result is not as expect)

@onursumer
Copy link
Collaborator Author

Not sure if sorting annotation column is still useful in this case, probably better to disable it if we don't want to sort, or make it work properly (now if you sort annotation column, the result is not as expect)

@leexgh good point. I think for now we can disable sorting. I will open a separate ticket for the sort issue in cBioPortal repo. That needs to be fixed in the library itself.

@onursumer
Copy link
Collaborator Author

New ticket opened for annotation sort issue: cBioPortal/cbioportal/issues/8247

@onursumer onursumer merged commit edf3c4d into knowledgesystems:site-redesign Jan 13, 2021
@onursumer onursumer deleted the annotation-column-tweaks branch January 13, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants