Feat: upgrade querystring to URLSearchParams

[adaex]

close #1570

I'm not sure if this is necessary.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (5ee832c) to head (09d7d1f).
Report is 97 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1574   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      507           
  Branches      142      142           
=======================================
  Hits          505      505           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonathanong]

thanks! looking more into this, do you think it would be better if we just exposed the URLSearchParams instance as ctx.request.searchParams or something?

yeah, not necessary, but query string is considered legacy

[adaex]

@jonathanong

I think exposed the URLSearchParams instance as ctx.request.searchParams is a good idea.

How do you see #1575 ? If there is no problem, I will continue to complete it.

[miwnwski]

LGTM, but requires some additions.

If you don't mind exposing searchParams as Request#searchParams, and it would be nice to add a line to History.md as well as this is a breaking change. Also a test or two for completeness!

Since this is available from node 10+ it's mergeable once the PR is massaged a bit.

I closed #1575 in favour of this PR.

[jonathanong]

merged #1828