Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Replace node querystring with URLSearchParams #1828

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Feat: Replace node querystring with URLSearchParams #1828

merged 5 commits into from
Aug 31, 2024

Conversation

kravorkid
Copy link
Contributor

@kravorkid kravorkid commented Jun 24, 2024 •
edited
Loading

Fix #1570 Replace node querystring with URLSearchParams it mimics the way that querystring works

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@kravorkid kravorkid mentioned this pull request Jun 24, 2024
Closed
@jonathanong jonathanong merged commit 7cf1462 into koajs:master Aug 31, 2024
5 checks passed
@jonathanong jonathanong mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Platform: upgrade query string to URLSearchParams
2 participants
@kravorkid @jonathanong