Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the newer package manager #2197

Closed
yangwao opened this issue Feb 3, 2022 · 12 comments · Fixed by #2643
Closed

Migrate to the newer package manager #2197

yangwao opened this issue Feb 3, 2022 · 12 comments · Fixed by #2643
Assignees
Labels
$ ~<50usd $$ ~51-150usd p3 non-core, affecting less than 40% v2.2

Comments

@yangwao
Copy link
Member

yangwao commented Feb 3, 2022

Someone can take care and migrate to yarn v2, it should cut us time for development and fresh installs

Why we should migrate -> https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern

Note to @yangwao -- check deployments if works ok!

  • on beta
  • on production

Ref

@yangwao yangwao added $ ~<50usd p3 non-core, affecting less than 40% v2.2 labels Feb 3, 2022
@yangwao
Copy link
Member Author

yangwao commented Feb 3, 2022

Old yarn 1.22.10

23.93s

Compiled successfully in 34.49s (I guess wont we get better performance)

yarn generate Done in 40.31s. (yarn v2/v3 won't impact this one I guess)
image

@vikiival vikiival linked a pull request Feb 3, 2022 that will close this issue
17 tasks
@preschian
Copy link
Member

I would suggest upgrade to pnpm instead of yarn v2 for now

I agree with this reason: https://twitter.com/sitnikcode/status/1474367850341097483

@yangwao
Copy link
Member Author

yangwao commented Mar 20, 2022

Interesting point

@yangwao
Copy link
Member Author

yangwao commented Mar 20, 2022

I would suggest upgrade to pnpm instead of yarn v2 for now

I agree with this reason: twitter.com/sitnikcode/status/1474367850341097483

But pnpm needs to be installed as extra I guess? But same as for yarn.
Do they have some lock files as well?
Curious about compatibility with CI/CD tools we are using tbh

@preschian
Copy link
Member

I would suggest upgrade to pnpm instead of yarn v2 for now
I agree with this reason: twitter.com/sitnikcode/status/1474367850341097483

But pnpm needs to be installed as extra I guess? But same as for yarn. Do they have some lock files as well? Curious about compatibility with CI/CD tools we are using tbh

pnpm has lock-files also

need to test the compatibility. vue3 already using pnpm + netlify
netlify/build#1633 (comment)

vue3 github actions with pnpm
https://github.com/vuejs/core/blob/main/.github/workflows/ci.yml#L16

@vikiival vikiival changed the title Migrate yarn v2 Migrate to the newer package manager Mar 21, 2022
@vikiival
Copy link
Member

Just wanted to open that we can migrate to pnpm seems like yarn v1 becomes deprecated soon

@preschian
Copy link
Member

I tried to migrate to pnpm, it seems like too many errors with types. I tried to fix it little by little in here preschian#1. seems like not an easy task tho

Screen Shot 2022-03-22 at 8 08 40 PM

@vikiival do you have any concerns about this PR? #2529 it can help a little about migration to pnpm

@vikiival
Copy link
Member

vikiival commented Mar 22, 2022

@vikiival do you have any concerns about this PR? #2529 it can help a little about migration to pnpm

Just think it will bloat the package size and still you haven't resolved the issue with polkadot packages (hint do not add them as the depencdency) :)

@preschian
Copy link
Member

unfortunately, it will cause an error in pnpm if the packages are not installed. because pnpm use different strategies https://pnpm.io/motivation#creating-a-non-flat-node_modules-directory

for example:
Screen Shot 2022-03-22 at 8 28 13 PM

let me try https://pnpm.io/npmrc#node-linker in pnpm, it should use npm/yarn behaviour

@preschian
Copy link
Member

able to run in local using pnpm with node-linker=hoisted enabled. need to find out these postcss warnings, where is this come from 🤔

Screen Shot 2022-03-22 at 8 37 55 PM

@vikiival
Copy link
Member

May some of these can help
postcss/postcss#1171
https://stackoverflow.com/questions/38889675/how-to-suppress-warnings-using-webpack-and-post-css

@yangwao yangwao added the $$ ~51-150usd label Mar 22, 2022
@preschian preschian mentioned this issue Mar 23, 2022
17 tasks
@yangwao
Copy link
Member Author

yangwao commented Mar 25, 2022

need to test the compatibility. vue3 already using pnpm + netlify netlify/build#1633 (comment)

vue3 github actions with pnpm https://github.com/vuejs/core/blob/main/.github/workflows/ci.yml#L16

oh just noticed Svelte is running pnpm as well, I'm pretty excited then tho!
netlify/build#1633 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd $$ ~51-150usd p3 non-core, affecting less than 40% v2.2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants