Switch to pnpm #2643

preschian · 2022-03-23T04:50:38Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

PR closes Migrate to the newer package manager #2197
switch package manager to pnpm

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
I've tested PR on mobile and everything seems works
I found edge cases
I've written some unit tests 🧪

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot

My fix has changed something on UI; a screenshot is best to understand changes for others.

tested in GitHub actions and netlify: https://github.com/preschian/nft-gallery/pull/1/checks

netlify · 2022-03-23T04:50:43Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`bd6d6f6`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/623de43d5589f00009f82f28
😎 Deploy Preview	https://deploy-preview-2643--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

preschian · 2022-03-23T05:14:20Z

seems like need to update netlify not to use yarn in the netlify dashboard. it should be able to deploy to netlify, take a look at this PR-test preschian#1

cc @yangwao @vikiival

yangwao · 2022-03-24T12:29:39Z

what will be build commands?

You can also please update it in, as we have mentioned yarn there, if it builds, I'm happy to change it over to pnpm.

Contributing.md
https://github.com/kodadot/nft-gallery/blob/main/FIRST_TIME.md

preschian · 2022-03-24T12:36:48Z

noted, I forgot about the docs. Just realised after doing the #2644 issue 😅
that's why I switch the PR to draft again haha

this is my netlify config, just leave it blank

preschian · 2022-03-24T12:55:52Z

suggestion from @yangwao

wrap long command in package.json
build != generate
test it in cloudflare pages

preschian · 2022-03-25T08:13:09Z

tested in:

cloudflare pages: switch to pnpm preschian/nft-gallery#1 (comment)
- skip npm install in cf: pass NPM_FLAGS = --version as env. source
netlify: switch to pnpm preschian/nft-gallery#1 (comment)
- skip npm install in netlify: leave it blank in build settings
local development

improvements:

	yarn	pnpm
Netlify Deployment	5m	3m
Install Deps in Actions	1m 25s	28s

yangwao · 2022-03-25T10:09:05Z

tested in:

cloudflare pages: switch to pnpm preschian/nft-gallery#1 (comment)

skip npm install in cf: pass NPM_FLAGS = --version as env. source

netlify: switch to pnpm preschian/nft-gallery#1 (comment)

skip npm install in netlify: leave it blank in build settings

local development

improvements:

yarn pnpm
Netlify Deployment 5m

3m
Install Deps in Actions [1m 25s](https://github.com/kodadot/nft-gallery/runs/5676422402?check_suite_focus=true#step:4:35) [**28s**](https://github.com/kodadot/nft-gallery/runs/5687650302?check_suite_focus=true#step:6:467)

impressive time savings.
Curious if you would be keen to write an article on how we've migrated from yarn to pnpm?
Some people might find it interesting as we are still early!
This morning found friends deciding between npm and yarn 😅.

We are usually publishing at https://medium.com/kodadot :)

yangwao · 2022-03-25T12:25:55Z

Once #2668 is resolved, we can check on deploying pnpm

yangwao · 2022-03-25T14:54:17Z

tried with with no build instruction or with npm run generate:pnpm and resulting in same errors

maybe you have something different in your setup?

yangwao

maybe adding npm i -g pnpm would help

package.json

netlify.toml

package.json

yangwao · 2022-03-25T15:26:16Z

I'm confused @preschian

Seems by this log it uses yarn?
however, build instructions are
npm i -g pnpm;npm run generate:pnpm

maybe bc of yarn.lock ? ook, yarn.lock is not present, I'm out of hints.

https://app.netlify.com/sites/koda-nuxt/deploys/623ddcd0b5c58c0008c07402

yangwao · 2022-03-25T15:29:47Z

oh got hint

yangwao · 2022-03-25T15:34:38Z

(Netlify Build completed in 3m 50.3s)

Against the previous ~ 4m20 isn't that big saving :|

Cached

4:40:15 PM: (Netlify Build completed in 2m 48.7s)

Bit better! :)

yangwao · 2022-03-25T15:42:11Z

Oh apparently need merge something or remove file?

preschian · 2022-03-25T15:44:27Z

@yangwao will update

yangwao · 2022-03-27T09:31:56Z

sending upper bound with something extra on top! :)

pay 300 usd

thank you @preschian for your amazing all-around cooperation!

yangwao · 2022-03-27T09:32:01Z

😍 Perfect, I’ve sent the payout
💵 $300 @ 167.64 USD/KSM ~ 1.79 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xded4881c8c32fc626530860209874b1851c788a020a0ea76ae33c9c00a86efaf

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

preschian added 19 commits March 22, 2022 20:16

add pnpm-lock

19e87f1

add node-linker=hoisted

a3bb162

adjust node engines

5d97113

update reviewdog actions

eed2c03

try use npmrc in github actions

c422b91

cat npmrc

c1e2c2d

pnpm run_install: true

f433150

set postcss null

b6d10d4

test without use-npmrc

d1cfd69

unused github actions

f941e68

adjust netlify.toml

96ef2ee

run pnpm with npx

6c360fb

add prebuild command

6a33236

remove -r on prebuild

745f67d

test without context

2ef4aa3

test prebuild command

28b81e0

adjust github actions

17cad2f

reordering nodejs in github actions

e720bdb

move prebuild command to netlify.toml

85b212c

Merge branch 'main' of github.com:preschian/nft-gallery into switch-pnpm

816471b

preschian changed the title ~~#2197 Switch to pnpm~~ Switch to pnpm Mar 23, 2022

preschian added 2 commits March 23, 2022 11:58

test ignore deepsource invalid rules

e53063d

not works

8ef56a5

preschian marked this pull request as ready for review March 23, 2022 05:36

preschian marked this pull request as draft March 23, 2022 06:59

preschian added 3 commits March 25, 2022 12:16

update lock files

d7e7c4c

add pnpm cache in github actions

5518764

update docs from yarn to pnpm

4319add

preschian marked this pull request as ready for review March 25, 2022 08:13

yangwao mentioned this pull request Mar 25, 2022

How we've migrated from yarn to pnpm #2671

Open

add engine strict

7fbf812

yangwao reviewed Mar 25, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

netlify.toml Outdated Show resolved Hide resolved

netlify.toml Outdated Show resolved Hide resolved

Update netlify.toml

0d1fde7

yangwao reviewed Mar 25, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

yangwao and others added 2 commits March 25, 2022 16:12

removing only-allow for netlify and cf

aa2c9bb

fixing package.json its like "99

3dbfaa2

yangwao enabled auto-merge March 25, 2022 15:41

Merge branch 'main' of github.com:preschian/nft-gallery into switch-pnpm

91e5855

auto-merge was automatically disabled March 25, 2022 15:46
Head branch was pushed to by a user without write access

update lockfile

bd6d6f6

yangwao merged commit 065920e into kodadot:main Mar 25, 2022

preschian deleted the switch-pnpm branch March 25, 2022 16:52

yangwao added the paid pull-request has been paid label Mar 27, 2022

yangwao mentioned this pull request Apr 8, 2022

Optimize builds - Over build minutes on Netlify #279

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to pnpm #2643

Switch to pnpm #2643

preschian commented Mar 23, 2022 •

edited

Loading

netlify bot commented Mar 23, 2022 •

edited

Loading

preschian commented Mar 23, 2022

yangwao commented Mar 24, 2022

preschian commented Mar 24, 2022

preschian commented Mar 24, 2022 •

edited

Loading

preschian commented Mar 25, 2022

yangwao commented Mar 25, 2022

yangwao commented Mar 25, 2022

yangwao commented Mar 25, 2022 •

edited

Loading

yangwao left a comment

yangwao commented Mar 25, 2022 •

edited

Loading

yangwao commented Mar 25, 2022

yangwao commented Mar 25, 2022 •

edited

Loading

yangwao commented Mar 25, 2022

preschian commented Mar 25, 2022

yangwao commented Mar 27, 2022

yangwao commented Mar 27, 2022

Switch to pnpm #2643

Switch to pnpm #2643

Conversation

preschian commented Mar 23, 2022 • edited Loading

PR type

What's new?

Before submitting Pull Request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot

netlify bot commented Mar 23, 2022 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

preschian commented Mar 23, 2022

yangwao commented Mar 24, 2022

preschian commented Mar 24, 2022

preschian commented Mar 24, 2022 • edited Loading

preschian commented Mar 25, 2022

yangwao commented Mar 25, 2022

yangwao commented Mar 25, 2022

yangwao commented Mar 25, 2022 • edited Loading

yangwao left a comment

Choose a reason for hiding this comment

yangwao commented Mar 25, 2022 • edited Loading

yangwao commented Mar 25, 2022

yangwao commented Mar 25, 2022 • edited Loading

yangwao commented Mar 25, 2022

preschian commented Mar 25, 2022

yangwao commented Mar 27, 2022

yangwao commented Mar 27, 2022

preschian commented Mar 23, 2022 •

edited

Loading

netlify bot commented Mar 23, 2022 •

edited

Loading

preschian commented Mar 24, 2022 •

edited

Loading

yangwao commented Mar 25, 2022 •

edited

Loading

yangwao commented Mar 25, 2022 •

edited

Loading

yangwao commented Mar 25, 2022 •

edited

Loading