Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧶 Upgrading to the yarn v2 berry #2199

Closed
wants to merge 5 commits into from
Closed

🧶 Upgrading to the yarn v2 berry #2199

wants to merge 5 commits into from

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Feb 3, 2022

  • 🧶 v2
  • 🧶 v2

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@vikiival vikiival self-assigned this Feb 3, 2022
@vikiival vikiival requested a review from yangwao February 3, 2022 13:19
@netlify
Copy link

netlify bot commented Feb 3, 2022

❌ Deploy Preview for koda-nuxt failed.

🔨 Explore the source changes: 6f3338a

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61fbdcc32eaeb200075b8fa4

@vikiival vikiival changed the title 🧶 v2 🧶 Upgrading to the yarn version two Feb 3, 2022
@vikiival vikiival linked an issue Feb 3, 2022 that may be closed by this pull request
@yangwao
Copy link
Member

yangwao commented Feb 3, 2022

Maybe related to set netlify netlify/build-image#612 (comment)

@yangwao yangwao changed the title 🧶 Upgrading to the yarn version two 🧶 Upgrading to the yarn v2 berry Feb 3, 2022
@vikiival
Copy link
Member Author

vikiival commented Feb 3, 2022

Netlify issues regarding to yarn v2:
netlify/build-image#612
netlify/build-image#465
netlify/build#1535

@vikiival vikiival closed this Feb 3, 2022
@vikiival vikiival deleted the yarn-berry branch March 15, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to the newer package manager
2 participants