-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contributing and first_time pages #2644
add contributing and first_time pages #2644
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, we use MarkdownIt package with i18n plugin why would you remove it?
Plus do we really need this highlight.js
stuff? I think it could be done using bulma component.
maybe I miss something. I didn't mean to remove the existing one, can you refer to which file? in package.json I only added highlight.js is for syntax highlighting, especially in
I couldn't find bulma component for syntax highlight. can you send me the direct link, I only find this github issue jgthms/bulma#690 |
We use in some component
Oups, my eyes saw a deleted line (markdown-it) in the yarn.lock and I thought the package was gone.
Rather than integrating
My bad, I didn't understand that it was a code block |
I tried https://github.com/nuxt-contrib/markdownit-loader before, but got an error when consuming the pipeline for the snyk scanner also fail, I assume because of that package (I can't see snyk log) https://app.snyk.io/org/kodadot/pr-checks/474ef4f3-3452-48a5-905c-e24fd2fd1fb6 those packages actually have different use cases:
another solution is to find another loader to turn let me try another loader |
@roiLeo updated, following your suggestions, now use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final note on small things I would change:
- remove ContentMarkdown component and keep the logic in pages
- change snake_case page to kebab-case
- create an utils file with highlight.js config
What's are final difference against Seems doable |
in #2021: it seems like limitation with In this PR, extend webpack config using |
pay 100 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
oh I forgot, if we can link contribute to footer 😇 |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot