Support Python 3.11 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m.KEY, which works on Python<3.11 but broke in 3.11 (see: python/cpython#100458)
Codecov Report
@@ Coverage Diff @@
## trunk #7 +/- ##
========================================
Coverage ? 85.58%
========================================
Files ? 92
Lines ? 5860
Branches ? 640
========================================
Hits ? 5015
Misses ? 763
Partials ? 82
|
|
Will follow up with an update to the Supported Python Versions table on docs.kolena.io. |
munkyshi
reviewed
May 10, 2023
Comment on lines
-17
to
-19
| class SampleType(str, Enum): | ||
| LOCATOR = "LOCATOR" | ||
| LOCATOR_TEXT = "LOCATOR_TEXT" |
There was a problem hiding this comment.
Is this no longer being used?
There was a problem hiding this comment.
Wasn't being used. Was from when we intended to have different sample types within the kolena.detection system, which has been superseded by kolena.workflow.
ly-kolena
reviewed
May 10, 2023
ly-kolena
approved these changes
May 10, 2023
…a.fr._consts; rename some already-hidden classes to remove leading underscore (already in underscored files)
gordonhart
commented
May 10, 2023
| from kolena.fr.datatypes import _ImageChipsDataFrame | ||
|
|
||
|
|
||
| def upload_image_chips(df: _ImageChipsDataFrame, batch_size: int = BatchSize.UPLOAD_CHIPS.value) -> None: |
There was a problem hiding this comment.
Moved to kolena.fr._utils because this is an FR-specific implementation.
munkyshi
approved these changes
May 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of note:
Narrower version constraints on
numpyandpandasfor ≥3.11Skipping
pre-commiton 3.11 for the same reason it was already skipped on 3.10Python 3.11 changed stringification for
class MyEnum(str, Enum)and theintequivalent. Before, ifMyEnum.MY_VALUEwas declared withmy_value,str(MyEnum.MY_VALUE)yieldedmy_value. We relied on this behavior in a number of places as a means of defining namespaced consts. In Python 3.11,str(MyEnum.MY_VALUE)yieldsMyEnum.MY_VALUE. To unbreak this in a backwards-compatible way, all usages have been updated to explicitly reference the associated value, e.g.MyEnum.MY_VALUE.value.See Enum with
strorintMixin Breaking Change in Python 3.11 python/cpython#100458 for more discussion on this breakage.