-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.7 #347
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #347 +/- ##
==========================================
+ Coverage 93.73% 93.92% +0.18%
==========================================
Files 118 115 -3
Lines 7682 7490 -192
Branches 926 890 -36
==========================================
- Hits 7201 7035 -166
+ Misses 368 343 -25
+ Partials 113 112 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
{ version = ">=1.23", python = ">=3.11" }, | ||
] | ||
pandas = [ | ||
{ version = ">=1.1,<1.6", python = ">=3.7,<3.11" }, | ||
{ version = ">=1.1,<1.6", python = ">=3.8,<3.11" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking question: can this be simplified? something like pandas = "<1.6"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've run into issues with low pandas
versions and had to explicitly add the >=1.1
constraint. The different pins for Python 3.11 are necessary (went through this trial-and-error on #7)
Remove support for EOL Python 3.7 now that it is no longer supported by AWS SDKs. 3.7 has been officially deprecated since June 2023.
Fixes KOL-2344