Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.7 #347

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Remove support for Python 3.7 #347

merged 4 commits into from
Dec 14, 2023

Conversation

gordonhart
Copy link
Member

Remove support for EOL Python 3.7 now that it is no longer supported by AWS SDKs. 3.7 has been officially deprecated since June 2023.

Fixes KOL-2344

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce15d0d) 93.73% compared to head (8914b3e) 93.92%.

❗ Current head 8914b3e differs from pull request most recent head c2546dd. Consider uploading reports for the commit c2546dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk     #347      +/-   ##
==========================================
+ Coverage   93.73%   93.92%   +0.18%     
==========================================
  Files         118      115       -3     
  Lines        7682     7490     -192     
  Branches      926      890      -36     
==========================================
- Hits         7201     7035     -166     
+ Misses        368      343      -25     
+ Partials      113      112       -1     
Flag Coverage Δ
integration 73.17% <ø> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

{ version = ">=1.23", python = ">=3.11" },
]
pandas = [
{ version = ">=1.1,<1.6", python = ">=3.7,<3.11" },
{ version = ">=1.1,<1.6", python = ">=3.8,<3.11" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking question: can this be simplified? something like pandas = "<1.6"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've run into issues with low pandas versions and had to explicitly add the >=1.1 constraint. The different pins for Python 3.11 are necessary (went through this trial-and-error on #7)

@gordonhart gordonhart marked this pull request as ready for review December 14, 2023 19:41
@gordonhart gordonhart requested review from a team as code owners December 14, 2023 19:41
@gordonhart gordonhart enabled auto-merge (squash) December 14, 2023 19:42
@gordonhart gordonhart merged commit ab94b07 into trunk Dec 14, 2023
37 of 38 checks passed
@gordonhart gordonhart deleted the gh/remove-3.7 branch December 14, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants