Fix: Support prettier v1.6.0 config (prettier#46)

kombucha · Sep 17, 2017 · 2aa0cd3 · 2aa0cd3
1 parent 95f0808
commit 2aa0cd3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -54,8 +54,7 @@ Then, in your `.eslintrc.json`:
 ## Options
 
 * The first option:
-
-  - Objects are passed directly to Prettier as [options](https://github.com/prettier/prettier#api). Example:
+  - Objects are passed directly to Prettier as [options](https://github.com/prettier/prettier#options). Example:
 
     ```json
     "prettier/prettier": ["error", {"singleQuote": true, "parser": "flow"}]
@@ -78,6 +77,7 @@ Then, in your `.eslintrc.json`:
       "parser": "flow"
     }]
     ```
+  NB: This option will merge and override any config set with `.prettierrc` files (for Prettier < 1.7.0, [config files are ignored](https://github.com/prettier/eslint-plugin-prettier/issues/46))
 
 * The second option:
 

diff --git a/eslint-plugin-prettier.js b/eslint-plugin-prettier.js
@@ -306,11 +306,6 @@ module.exports = {
         ]
       },
       create(context) {
-        const prettierOptions =
-          context.options[0] === 'fb'
-            ? FB_PRETTIER_OPTIONS
-            : context.options[0];
-
         const pragma = context.options[1]
           ? context.options[1].slice(1) // Remove leading @
           : null;
@@ -342,12 +337,31 @@ module.exports = {
           }
         }
 
+        if (prettier) {
+          prettier.clearConfigCache();
+        }
+
         return {
           Program() {
             if (!prettier) {
               // Prettier is expensive to load, so only load it if needed.
               prettier = require('prettier');
             }
+
+            const eslintPrettierOptions =
+              context.options[0] === 'fb'
+                ? FB_PRETTIER_OPTIONS
+                : context.options[0];
+            const prettierRcOptions =
+              prettier.resolveConfig && prettier.resolveConfig.sync
+                ? prettier.resolveConfig.sync(context.getFilename())
+                : null;
+            const prettierOptions = Object.assign(
+              {},
+              prettierRcOptions,
+              eslintPrettierOptions
+            );
+
             const prettierSource = prettier.format(source, prettierOptions);
             if (source !== prettierSource) {
               const differences = generateDifferences(source, prettierSource);