Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prettier v1.6.0 config #46

Closed
jaydenseric opened this issue Aug 29, 2017 · 7 comments · Fixed by #553
Closed

Support prettier v1.6.0 config #46

jaydenseric opened this issue Aug 29, 2017 · 7 comments · Fixed by #553

Comments

@jaydenseric
Copy link

jaydenseric commented Aug 29, 2017

Prettier v1.6.0 is out, and it implements cosmiconfig for options.

This plugin currently requires prettier config to be set within ESLint config. It would be awesome to deprecate this and let prettier derive the config itself.

@not-an-aardvark
Copy link
Member

Seems reasonable to me. It looks like prettier exposes a resolveConfig function for getting a config, so I think it should be pretty simple to let prettier handle config resolution.

@not-an-aardvark
Copy link
Member

Actually, I think this is blocked by prettier/prettier#2722.

@goldo
Copy link

goldo commented Sep 5, 2017

@not-an-aardvark since it has been merged, I guess we have to wait for the next prettier release ?

@not-an-aardvark
Copy link
Member

Yes, that's correct.

@azz
Copy link
Member

azz commented Sep 14, 2017

Tracking for 1.6.2 which will include .sync() prettier/prettier#2804

@kombucha
Copy link
Contributor

🎉 https://github.com/prettier/prettier/releases/tag/1.7.0

kombucha added a commit to kombucha/eslint-plugin-prettier that referenced this issue Sep 17, 2017
kombucha added a commit to kombucha/eslint-plugin-prettier that referenced this issue Sep 17, 2017
kombucha added a commit to kombucha/eslint-plugin-prettier that referenced this issue Sep 17, 2017
kombucha added a commit to kombucha/eslint-plugin-prettier that referenced this issue Sep 17, 2017
@not-an-aardvark
Copy link
Member

Support for prettier config files has been published in eslint-plugin-prettier@2.3.0. Thanks to @kombucha for implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants