drain should not be called by multiple coroutines #114

komuw · 2019-05-29T10:40:12Z

Line 1312 in 5ebeffe

await self.writer.drain()

We need to acquire an asyncio.Lock around that code.

komuw · 2019-05-29T10:41:26Z

I think we also need to acquire an asyncio.Lock for the code to re-establish connection:

Line 1206 in ae4bae4

async def re_establish_conn_bind(self, smpp_command: str, log_id: str) -> None:

What: - Introduce a configurable timeout when trying to connect to SMSC - Try and detect when the connection to SMSC is disconnected and attempt to re-connect & re-bind - bugfix; `asyncio.streams.StreamWriter.drain` should not be called concurrently by multiple coroutines[1] - when shutting down, `naz` now tries to make sure that write buffers are properly flushed[2][3] Why: - Make `naz` more failure tolerant - Fixes: #67 - Fixes: #114 - Fixes: #116 - Fixes: #117 - Fixes: #120 References: 1. https://bugs.python.org/issue29930 2. https://vorpus.org/blog/some-thoughts-on-asynchronous-api-design-in-a-post-asyncawait-world/ 3. aio-libs/aiohttp#1369

komuw added the bug Something isn't working label May 29, 2019

komuw mentioned this issue May 31, 2019

Issues/67 #113

Merged

komuw closed this as completed in #113 May 31, 2019

Provide feedback