Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naz.Client.shutdown should call client.writer.drain #117

Closed
komuw opened this issue May 29, 2019 · 0 comments · Fixed by #113
Closed

naz.Client.shutdown should call client.writer.drain #117

komuw opened this issue May 29, 2019 · 0 comments · Fixed by #113
Labels
bug Something isn't working

Comments

@komuw
Copy link
Owner

komuw commented May 29, 2019

in naz.Client.shutdown we call client.writer.close
We need to call client.writer.drain before calling close.

And it also should probably call client.writer._transport.set_write_buffer_limits(0) before calling client.writer.drain

aio-libs/aiohttp#1369
@komuw komuw added the bug Something isn't working label May 29, 2019
@komuw komuw mentioned this issue May 31, 2019
Merged
komuw added a commit that referenced this issue May 31, 2019
@komuw
Issues/67 (#113)
5f34f83 
What:
- Introduce a configurable timeout when trying to connect to SMSC
- Try and detect when the connection to SMSC is disconnected and attempt to re-connect & re-bind
- bugfix; `asyncio.streams.StreamWriter.drain` should not be called concurrently by multiple coroutines[1]
- when shutting down, `naz` now tries to make sure that write buffers are properly flushed[2][3]

Why:
- Make `naz` more failure tolerant
- Fixes: #67
- Fixes: #114
- Fixes: #116
- Fixes: #117
- Fixes: #120

References:
1. https://bugs.python.org/issue29930
2. https://vorpus.org/blog/some-thoughts-on-asynchronous-api-design-in-a-post-asyncawait-world/
3. aio-libs/aiohttp#1369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues/67 komuw/naz
1 participant
@komuw