Adds a first unit test for SessionDao as a proof of concept. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx! It might be conflicted with #129 . |
|
Ah ok. Looks like so. Please prioritize #129 first. Then I can rebase on top of that. |
|
Thanks! It is really helpful for me because I don't have enough knowledge of testing. |
|
LGTM! |
|
LGTM! @thagikura #129 was merged. Could you rebase? 🙇 |
This test makes a mock instances for all dependencies including OrmaDatabase. So shouldn't be affected by the changes of any dependencies.
thagikura
force-pushed
the
add_unit_tests_for_SessionDao
branch
from
a4aa4f5 to
a3a51ff
Compare
|
Thanks for the review! Done. Rebased on top of the latest master. |
|
Great:D |
hotchemi
added a commit
that referenced
this pull request
Feb 11, 2016
Adds a first unit test for SessionDao as a proof of concept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test makes mock instances for all dependencies including OrmaDatabase.
So shouldn't be affected by the changes of any dependencies.