use direct associations with Orma v2 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
|
|
||
| @Table | ||
| public class Contributor { | ||
|
|
||
| @PrimaryKey | ||
| @PrimaryKey(auto = false) |
There was a problem hiding this comment.
One question of Orma.
What is this option?
There was a problem hiding this comment.
In default settings, Orma's @PrimaryKey is automatically assigned by SQLite, even if autoincrement = true is not specified.
In this case, each ID comes from the API so it is not an "auto" value.
You can see the difference in Contributor_Schema.java by comparing both cases: @PrimaryKey(auto = true) (default) and @PrimaryKey(auto = false).
|
LGTM!! |
konifar
added a commit
that referenced
this pull request
Feb 22, 2016
use direct associations with Orma v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Orma v2.0 to use direct associations where an Orma model has other Orma models as a reference.
Unfortunately this change seems conflict with #132, which fails with this PR. In this case, however, Mockito makes no sense because Orma works with Robolectric and you can test input and output of Orma/SessionDao without Mockito.