Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Dependency string parsing fails when dependency is not JAR #482

Closed
1 task done
jmle opened this issue Feb 2, 2024 · 0 comments · Fixed by #483
Closed
1 task done

[BUG] Dependency string parsing fails when dependency is not JAR #482

jmle opened this issue Feb 2, 2024 · 0 comments · Fixed by #483
Assignees
@jmle
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jmle
Copy link
Contributor

jmle commented Feb 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3.0

Priority

Critical

Current Behavior

Dependencies must not necessarily be JARs, they can also be POMs for instance (ie, hibernate-search-orm-5.11.11.Final.pom.sha1)

When trying to parse the string, the process will fail in this case. See these lines of code.

Expected Behavior

The dependency analysis should take into account these cases

How Reproducible

Always (Default)

Steps To Reproduce

See failing windup-shim testing of rule hibernate-search-01040-test.

Environment

No response

Anything else?

No response
@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2024
@jmle jmle added this to Planning Feb 2, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Feb 2, 2024
@jmle jmle self-assigned this Feb 2, 2024
@jmle jmle mentioned this issue Feb 5, 2024
Merged
shawn-hurley pushed a commit that referenced this issue Feb 8, 2024
@jmle
🐛 Try pom packaging if jar packaging fails (#483)
dbd7d35 
Fixes #482

---------

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Planning Feb 8, 2024
pranavgaikwad pushed a commit to pranavgaikwad/analyzer-lsp that referenced this issue Feb 21, 2024
@jmle @pranavgaikwad
🐛 Try pom packaging if jar packaging fails (konveyor#483)
2d0febb 
Fixes konveyor#482

---------

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmle jmle

Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Try pom packaging if jar packaging fails jmle/analyzer-lsp
1 participant
@jmle