🐛 Bucket getdir #525
Merged
🐛 Bucket getdir #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam
approved these changes
Oct 17, 2023
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Oct 17, 2023
| } | ||
| h.Attachment(ctx, pathlib.Base(input)+".tar.gz") | ||
| ctx.Writer.Header().Set(Directory, DirectoryExpand) |
There was a problem hiding this comment.
hint: Add header ^
Signed-off-by: Jeff Ortel <jortel@redhat.com>
aufi
pushed a commit
to aufi/tackle2-hub
that referenced
this pull request
Oct 30, 2023
The refactor to using the new `tar` package accidentally removed setting the X-Directory:Expand. As a result, the client is not expanding downloaded directory (tarball). --- Fixed API tests. The bucket directory test really needs 2+ files to be accurate. It missed this issue. Added the task bucket (subresource) test for symmetry. --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor to using the new
tarpackage accidentally removed setting the X-Directory:Expand.As a result, the client is not expanding downloaded directory (tarball).
Fixed API tests. The bucket directory test really needs 2+ files to be accurate. It missed this issue.
Added the task bucket (subresource) test for symmetry.