🐛 Bucket getdir

api/bucket.go

@@ -325,10 +325,10 @@ func (h *BucketOwner) getDir(ctx *gin.Context, input string, filter tar.Filter)
 	if err != nil {
 		_ = ctx.Error(err)
 		return
-	} else {
-		h.Attachment(ctx, pathlib.Base(input)+".tar.gz")
-		ctx.Status(http.StatusOK)
 	}
+	h.Attachment(ctx, pathlib.Base(input)+".tar.gz")
+	ctx.Writer.Header().Set(Directory, DirectoryExpand)
+	ctx.Status(http.StatusOK)
 	_ = tarWriter.AddDir(input)
 	return
 }

test/api/application/bucket_test.go

@@ -1,10 +1,10 @@
 package application
 
 import (
+	"io/ioutil"
+	"os"
 	"testing"
 
-	"github.com/konveyor/tackle2-hub/api"
-	"github.com/konveyor/tackle2-hub/binding"
 	"github.com/konveyor/tackle2-hub/test/assert"
 )
 
@@ -16,7 +16,15 @@ func TestApplicationBucket(t *testing.T) {
 	assert.Must(t, Application.Create(&application))
 
 	// Get the bucket to check if it was created.
-	err := Client.BucketGet(binding.Path(api.BucketRoot).Inject(binding.Params{api.ID: application.Bucket.ID}), "/dev/null")
+	destDir, err := ioutil.TempDir("", "destDir")
+	if err != nil {
+		t.Errorf(err.Error())
+	}
+	defer func() {
+		_ = os.RemoveAll(destDir)
+	}()
+	bucket := RichClient.Application.Bucket(application.ID)
+	err = bucket.Get("", destDir)
 	if err != nil {
 		t.Errorf(err.Error())
 	}

test/api/bucket/sample/sample2.txt

@@ -0,0 +1 @@
+The second file.

test/api/task/bucket_test.go

@@ -0,0 +1,30 @@
+package task
+
+import (
+	"io/ioutil"
+	"os"
+	"testing"
+
+	"github.com/konveyor/tackle2-hub/test/assert"
+)
+
+func TestTaskBucket(t *testing.T) {
+	task := Windup
+	// Create the application.
+	assert.Must(t, Task.Create(&task))
+	// Get the bucket to check if it was created.
+	destDir, err := ioutil.TempDir("", "destDir")
+	if err != nil {
+		t.Errorf(err.Error())
+	}
+	defer func() {
+		_ = os.RemoveAll(destDir)
+	}()
+	bucket := RichClient.Task.Bucket(task.ID)
+	err = bucket.Get("", destDir)
+	if err != nil {
+		t.Errorf(err.Error())
+	}
+	// Clean the application.
+	assert.Must(t, Task.Delete(task.ID))
+}