Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix task filtering and sorting. #659

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jun 13, 2024

Fix issues reported here.

  1. sorting seems to work only for id field i.e.
  2. filtering not supported for createUser and id fields( both listed in the enhancement)
  3. application name is missing in the response and in filtering. Filtering by application ID works but this is not so nice.
  4. priority is missing in the response and in the filtering
  5. for kind the filtering is supported by the server but it seems it's not included in the response

Filter and sorting: needed to support GORM join queries which qualifies fields by table.

Example: For a task query joined with application, produces all of the task fields qualified as table.column:

SELECT task.id, task.name ...

And the (joined) application fields prefixed with APPLICATION__

SELECT APPLICATION__ID, APPLICATION__NAME ...

jortel added 4 commits June 13, 2024 10:06
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel marked this pull request as ready for review June 13, 2024 17:54
if mark > 0 && s[mark-1] == '\\' {
name = s[:mark-1] + s[mark:]
return
}
Copy link
Contributor Author

@jortel jortel Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint: Support field names with (.) that are not nested resources (in the filter).

@jortel jortel requested a review from mansam June 13, 2024 18:05
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants