-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a task manager page and table #1931
Comments
This issue is currently awaiting triage. |
@dymurray, @JustinXHale, @rromannissen -- for your consideration |
@sjd78 couple of questions:
|
Good question. As long as we can do the action individually, we can add the bulk action.
https://github.com/konveyor/enhancements/tree/master/enhancements/multiple-provider#task-priority As of right now, the priority in a number starting a 0 and going up. I don't know if there is an upper bound. I also don't know if it makes sense to have a defined "increase / decrease priority 10%" of just a "set priority to this non-negative number" UX. I kinda like the defined "do this by 10%" kind of operation just to make a user bump their tasks multiple times instead of just bulk setting all of their task priorities to MAX_INT. @jortel - Thoughts on the priority and the increase or decrease operations? |
Perhaps not to begin with.
0-n low-high. |
Recommend the column order be:
instead of:
|
@jortel @rromannissen |
Support: konveyor/tackle2-ui#1931 Note: UI team requested alias for _queued_ states to be supported in filter. Ex: `?filter=state:queued`. closes: #641 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
Part-of: konveyor#1931 Reference-Url: konveyor/tackle2-hub#640
Part-of: konveyor#1931 Reference-Url: konveyor/tackle2-hub#640 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@jortel
|
Part-of: #1931 Reference-Url: konveyor/tackle2-hub#640 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Fix issues reported [here](konveyor/tackle2-ui#1931 (comment)). 1. sorting seems to work only for `id` field i.e. 2. filtering not supported for `createUser` and `id` fields( both listed in the enhancement) 3. application name is missing in the response and in filtering. Filtering by application ID works but this is not so nice. 4. `priority` is missing in the response and in the filtering 5. for `kind` the filtering is supported by the server but it seems it's not included in the response --- Filter and sorting: needed to support GORM join queries which qualifies fields by table. Example: For a task query joined with application, produces all of the task fields qualified as table.column: ``` SELECT task.id, task.name ... ``` And the (joined) application fields prefixed with `APPLICATION__` ``` SELECT APPLICATION__ID, APPLICATION__NAME ... ``` --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
Related improvements: 1. support restoring columns to initial configuration 2. clean up invalid columns stored in local storage Part-of: #1931 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Functional changes: 1. create task manager entry in the sidebar navigation list 2. place task page under /tasks route 3. present tasks in a server-filtered table 4. row actions supported: canceling, enable/disable preemption flag 5. use column management to hide optional columns: pod, started, terminated Related features: 1. make id property required in Task type 2. switch task update endpoint to use patch method 3. provide icon-to-state mapping that preserves original state names which are required for server filtering Resolves: #1931 --------- Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Summary
With the addition of automatic language discovery and to give the user more insight and control over discovery and analysis tasks, create a new Task Manager page and table.
Enhancement references:
Requirements
Base requirements:
Table columns to initially include at least:
Table filters and sorting to initially include at least:
Actions that can be performed:
Actions that cannot be performed for Tasks:
HUB enhancements that may be needed
See konveyor/tackle2-hub#640 for the filtering, sorting and pagination of the tasks endpoint to be used by the table. This will reduce the number of task activity logs accessed and sent to keep the table performant.
Mock ups
Base task manager table:
The text was updated successfully, but these errors were encountered: