Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error on unknown files #180

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

bouassaba
Copy link
Member

@bouassaba bouassaba commented Jul 17, 2024

Sorry guys, I ended up creating a Swiss knife here 🇨🇭🙈

  • Don't show an error when a file is unknown.
  • No longer consider failed-to-create-thumbnail an error, so the user can open the file anyways if there is a preview for it (one case is if the CLI we use to create thunbnails for 3D models using WebKit fails).
  • Button + API endpoint to clean up (dismiss) all failed tasks.
  • DISABLE_INSTALLER is now ENABLE_INSTALLER, so people running locally won't suddenly get stuff installing.
  • Fix TIFF image preview.
  • Fix CSV file preview;

Closes #174
Closes #168
Closes #166
Closes #167


Here it gives no error, the file can be downloaded but cannot be previewed:



Before one had to clean these up one by one:

@bouassaba bouassaba merged commit 9bcaced into main Jul 18, 2024
3 checks passed
@bouassaba bouassaba deleted the fix/no-error-for-unknown-files branch July 18, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants