fix: don't error on unknown files

api/docs/swagger.yaml

@@ -548,10 +548,10 @@ definitions:
     type: object
   service.SnapshotDetachOptions:
     properties:
-      fileID:
+      fileId:
         type: string
     required:
-    - fileID
+    - fileId
     type: object
   service.SnapshotList:
     properties:
@@ -3173,6 +3173,24 @@ paths:
       summary: Get Count
       tags:
       - Tasks
+  /tasks/dismiss:
+    post:
+      consumes:
+      - application/json
+      description: Dismiss All
+      operationId: tasks_dismiss_all
+      produces:
+      - application/json
+      responses:
+        "200":
+          description: OK
+        "500":
+          description: Internal Server Error
+          schema:
+            $ref: '#/definitions/errorpkg.ErrorResponse'
+      summary: Dismiss All
+      tags:
+      - Tasks
   /users:
     get:
       description: List

api/repo/task_repo.go

@@ -146,7 +146,7 @@ func (s *taskEntity) SetPayload(p map[string]string) {
 type TaskRepo interface {
 	Insert(opts TaskInsertOptions) (model.Task, error)
 	Find(id string) (model.Task, error)
-	GetIDs() ([]string, error)
+	GetIDs(userID string) ([]string, error)
 	GetCount(email string) (int64, error)
 	Save(task model.Task) error
 	Delete(id string) error
@@ -225,12 +225,12 @@ func (repo *taskRepo) Find(id string) (model.Task, error) {
 	return res, nil
 }
 
-func (repo *taskRepo) GetIDs() ([]string, error) {
+func (repo *taskRepo) GetIDs(userID string) ([]string, error) {
 	type Value struct {
 		Result string
 	}
 	var values []Value
-	db := repo.db.Raw("SELECT id result FROM task ORDER BY create_time DESC").Scan(&values)
+	db := repo.db.Raw("SELECT id result FROM task WHERE user_id = ? ORDER BY create_time DESC", userID).Scan(&values)
 	if db.Error != nil {
 		return []string{}, db.Error
 	}

api/router/task_router.go

@@ -38,6 +38,7 @@ func NewTaskRouter() *TaskRouter {
 func (r *TaskRouter) AppendRoutes(g fiber.Router) {
 	g.Get("/", r.List)
 	g.Get("/count", r.GetCount)
+	g.Post("/dismiss", r.DismissAll)
 	g.Get("/:id", r.Get)
 	g.Post("/:id/dismiss", r.Dismiss)
 }
@@ -169,6 +170,25 @@ func (r *TaskRouter) Dismiss(c *fiber.Ctx) error {
 	return c.SendStatus(http.StatusNoContent)
 }
 
+// DismissAll godoc
+//
+//	@Summary		Dismiss All
+//	@Description	Dismiss All
+//	@Tags			Tasks
+//	@Id				tasks_dismiss_all
+//	@Accept			json
+//	@Produce		json
+//	@Success		200
+//	@Failure		500	{object}	errorpkg.ErrorResponse
+//	@Router			/tasks/dismiss [post]
+func (r *TaskRouter) DismissAll(c *fiber.Ctx) error {
+	userID := GetUserID(c)
+	if err := r.taskSvc.DismissAll(userID); err != nil {
+		return err
+	}
+	return c.SendStatus(http.StatusNoContent)
+}
+
 // Create godoc
 //
 //	@Summary		Create

api/service/task_service.go

@@ -166,7 +166,7 @@ type TaskList struct {
 func (svc *TaskService) List(opts TaskListOptions, userID string) (*TaskList, error) {
 	var authorized []model.Task
 	if opts.Query == "" {
-		ids, err := svc.taskRepo.GetIDs()
+		ids, err := svc.taskRepo.GetIDs(userID)
 		if err != nil {
 			return nil, err
 		}
@@ -175,11 +175,11 @@ func (svc *TaskService) List(opts TaskListOptions, userID string) (*TaskList, er
 			return nil, err
 		}
 	} else {
-		orgs, err := svc.taskSearch.Query(opts.Query)
+		tasks, err := svc.taskSearch.Query(opts.Query)
 		if err != nil {
 			return nil, err
 		}
-		authorized, err = svc.doAuthorization(orgs, userID)
+		authorized, err = svc.doAuthorization(tasks, userID)
 		if err != nil {
 			return nil, err
 		}
@@ -307,6 +307,25 @@ func (svc *TaskService) Dismiss(id string, userID string) error {
 	return svc.deleteAndSync(id)
 }
 
+func (svc *TaskService) DismissAll(userID string) error {
+	ids, err := svc.taskRepo.GetIDs(userID)
+	if err != nil {
+		return err
+	}
+	authorized, err := svc.doAuthorizationByIDs(ids, userID)
+	if err != nil {
+		return err
+	}
+	for _, t := range authorized {
+		if t.HasError() {
+			if err := svc.deleteAndSync(t.GetID()); err != nil {
+				return err
+			}
+		}
+	}
+	return nil
+}
+
 func (svc *TaskService) Delete(id string) error {
 	return svc.deleteAndSync(id)
 }

conversion/.env

@@ -1,6 +1,6 @@
 PORT=8083
 
-DISABLE_INSTALLER=false
+ENABLE_INSTALLER=false
 
 # URLs
 API_URL="http://127.0.0.1:8080"

conversion/config/config.go

@@ -16,14 +16,14 @@ import (
 )
 
 type Config struct {
-	Port             int
-	APIURL           string
-	LanguageURL      string
-	MosaicURL        string
-	DisableInstaller bool
-	Security         SecurityConfig
-	Limits           LimitsConfig
-	S3               S3Config
+	Port            int
+	APIURL          string
+	LanguageURL     string
+	MosaicURL       string
+	EnableInstaller bool
+	Security        SecurityConfig
+	Limits          LimitsConfig
+	S3              S3Config
 }
 
 type SecurityConfig struct {
@@ -56,12 +56,12 @@ func GetConfig() *Config {
 		config = &Config{
 			Port: port,
 		}
-		if len(os.Getenv("DISABLE_INSTALLER")) > 0 {
-			v, err := strconv.ParseBool(os.Getenv("DISABLE_INSTALLER"))
+		if len(os.Getenv("ENABLE_INSTALLER")) > 0 {
+			v, err := strconv.ParseBool(os.Getenv("ENABLE_INSTALLER"))
 			if err != nil {
 				panic(err)
 			}
-			config.DisableInstaller = v
+			config.EnableInstaller = v
 		}
 		readURLs(config)
 		readSecurity(config)

conversion/identifier/file_identifier.go

@@ -80,6 +80,7 @@ func (fi *FileIdentifier) IsPlainText(path string) bool {
 		".yaml",
 		".toml",
 		".md",
+		".csv",
 	}
 	extension := filepath.Ext(path)
 	for _, v := range extensions {

conversion/pipeline/audio_video_pipeline.go

@@ -62,7 +62,7 @@ func (p *audioVideoPipeline) Run(opts client.PipelineRunOptions) error {
 		return err
 	}
 	// Here we intentionally ignore the error, as the media file may contain just audio
-	p.createThumbnail(inputPath, opts)
+	_ = p.createThumbnail(inputPath, opts)
 	if err := p.apiClient.PatchTask(opts.TaskID, client.TaskPatchOptions{
 		Fields: []string{client.TaskFieldName},
 		Name:   helper.ToPtr("Saving preview."),

conversion/pipeline/dispatcher.go

@@ -11,8 +11,6 @@
 package pipeline
 
 import (
-	"errors"
-
 	"github.com/kouprlabs/voltaserve/conversion/client"
 	"github.com/kouprlabs/voltaserve/conversion/errorpkg"
 	"github.com/kouprlabs/voltaserve/conversion/helper"
@@ -81,23 +79,6 @@ func (d *Dispatcher) Dispatch(opts client.PipelineRunOptions) error {
 		err = d.glbPipeline.Run(opts)
 	} else if id == model.PipelineZIP {
 		err = d.zipPipeline.Run(opts)
-	} else {
-		if err := d.apiClient.PatchSnapshot(client.SnapshotPatchOptions{
-			Options: opts,
-			Fields:  []string{client.SnapshotFieldStatus},
-			Status:  helper.ToPtr(client.SnapshotStatusError),
-		}); err != nil {
-			return err
-		}
-		err = errors.New("no matching pipeline found")
-		if err := d.apiClient.PatchTask(opts.TaskID, client.TaskPatchOptions{
-			Fields: []string{client.TaskFieldStatus, client.TaskFieldError},
-			Status: helper.ToPtr(client.TaskStatusError),
-			Error:  helper.ToPtr(errorpkg.GetUserFriendlyMessage(err.Error(), errorpkg.FallbackMessage)),
-		}); err != nil {
-			return err
-		}
-		return err
 	}
 	if err != nil {
 		if err := d.apiClient.PatchSnapshot(client.SnapshotPatchOptions{

conversion/pipeline/glb_pipeline.go

@@ -91,9 +91,8 @@ func (p *glbPipeline) createThumbnail(inputPath string, opts client.PipelineRunO
 			infra.GetLogger().Error(err)
 		}
 	}(tmpPath)
-	if err := p.glbProc.Thumbnail(inputPath, p.config.Limits.ImagePreviewMaxWidth, p.config.Limits.ImagePreviewMaxHeight, "rgb(255,255,255)", tmpPath); err != nil {
-		return err
-	}
+	// We don't consider failing the creation of the thumbnail as an error
+	_ = p.glbProc.Thumbnail(inputPath, p.config.Limits.ImagePreviewMaxWidth, p.config.Limits.ImagePreviewMaxHeight, "rgb(255,255,255)", tmpPath)
 	props, err := p.imageProc.MeasureImage(tmpPath)
 	if err != nil {
 		return err

conversion/pipeline/image_pipeline.go

@@ -85,15 +85,21 @@ func (p *imagePipeline) Run(opts client.PipelineRunOptions) error {
 			return err
 		}
 	}
+	defer func(path string) {
+		if err := os.Remove(path); errors.Is(err, os.ErrNotExist) {
+			return
+		} else if err != nil {
+			infra.GetLogger().Error(err)
+		}
+	}(imagePath)
 	if err := p.apiClient.PatchTask(opts.TaskID, client.TaskPatchOptions{
 		Fields: []string{client.TaskFieldName},
 		Name:   helper.ToPtr("Creating thumbnail."),
 	}); err != nil {
 		return err
 	}
-	if err := p.createThumbnail(imagePath, opts); err != nil {
-		return err
-	}
+	// We don't consider failing the creation of the thumbnail as an error
+	_ = p.createThumbnail(imagePath, opts)
 	if err := p.apiClient.PatchTask(opts.TaskID, client.TaskPatchOptions{
 		Fields: []string{client.TaskFieldName, client.TaskFieldStatus},
 		Name:   helper.ToPtr("Done."),
@@ -177,13 +183,6 @@ func (p *imagePipeline) convertTIFFToJPEG(inputPath string, imageProps client.Im
 	if err := p.imageProc.ConvertImage(inputPath, jpegPath); err != nil {
 		return nil, err
 	}
-	defer func(path string) {
-		if err := os.Remove(path); errors.Is(err, os.ErrNotExist) {
-			return
-		} else if err != nil {
-			infra.GetLogger().Error(err)
-		}
-	}(jpegPath)
 	stat, err := os.Stat(jpegPath)
 	if err != nil {
 		return nil, err

conversion/pipeline/pdf_pipeline.go

@@ -97,9 +97,8 @@ func (p *pdfPipeline) Run(opts client.PipelineRunOptions) error {
 
 func (p *pdfPipeline) createThumbnail(inputPath string, opts client.PipelineRunOptions) error {
 	tmpPath := filepath.FromSlash(os.TempDir() + "/" + helper.NewID() + ".png")
-	if err := p.pdfProc.Thumbnail(inputPath, 0, p.config.Limits.ImagePreviewMaxHeight, tmpPath); err != nil {
-		return err
-	}
+	// We don't consider failing the creation of the thumbnail as an error
+	_ = p.pdfProc.Thumbnail(inputPath, 0, p.config.Limits.ImagePreviewMaxHeight, tmpPath)
 	defer func(path string) {
 		if err := os.Remove(path); errors.Is(err, os.ErrNotExist) {
 			return

conversion/runtime/installer.go

@@ -25,7 +25,7 @@ func (d *Installer) IsRunning() bool {
 func (d *Installer) Start() {
 	go func() {
 		d.isRunning = true
-		if !d.config.DisableInstaller {
+		if d.config.EnableInstaller {
 			d.installCoreTools()
 			d.installGltfPipeline()
 			d.installScreenshotGLB()

docker-compose.yml

@@ -161,6 +161,7 @@ services:
       - ${VOLTASERVE_CONVERSION_PORT}:8083
     environment:
       - PORT=8083
+      - ENABLE_INSTALLER=true
       - API_URL=http://api:8080
       - LANGUAGE_URL=http://language:8084
       - MOSAIC_URL=http://mosaic:8085

ui/src/client/api/task.ts

@@ -7,7 +7,6 @@
 // the Business Source License, use of this software will be governed
 // by the GNU Affero General Public License v3.0 only, included in the file
 // licenses/AGPL.txt.
-
 import useSWR, { SWRConfiguration } from 'swr'
 import { apiFetcher } from '@/client/fetcher'
 
@@ -136,4 +135,11 @@ export default class TaskAPI {
       method: 'POST',
     })
   }
+
+  static async dismissAll() {
+    return apiFetcher({
+      url: `/tasks/dismiss`,
+      method: 'POST',
+    })
+  }
 }