-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links, update icons #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, revert back all changes of icons please. Changing them requires a better approach.
@@ -35,6 +35,18 @@ export const FooterSection = styled.section` | |||
flex-basis: auto; | |||
text-align: center; | |||
} | |||
|
|||
a { | |||
color: #FFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use colors from theme
src/components/Footer/Footer.tsx
Outdated
<FooterSection> | ||
<p> | ||
Національний технічний університет України"Київський політехнічний інститут імені Ігоря Сікорського" © 1998-{dayjs().year()} | ||
</p> | ||
<p> | ||
Адреса: Україна, 03056 м.Київ-56, проспект Перемоги, 37 | ||
Адреса: <a href="https://kpi.ua/location">Україна, 03056 м.Київ-56, проспект Перемоги, 37</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better use target="_blank" for links that lead outside of site.
src/components/Footer/Footer.tsx
Outdated
</p> | ||
</FooterSection> | ||
<FooterSection> | ||
<p> | ||
Використання матеріалу сайту тільки з обов’язковим посиланням на schedule.kpi.ua | ||
Використання матеріалу сайту тільки з обов’язковим посиланням на <a href="https://schedule.kpi.ua">schedule.kpi.ua</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to keep a link to a site itself?
This reverts commit 470b3dc.
No description provided.