Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links, update icons #242

Merged
merged 6 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified public/apple-touch-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/favicon-48x48.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/favicon.ico
Binary file not shown.
1 change: 1 addition & 0 deletions public/favicon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/icon-192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/icon-512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions public/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"short_name": "React App",
"name": "Create React App Sample",
"short_name": "Розклад",
"name": "Розклад | КПІ ім. Ігоря Сікорського",
"icons": [
{
"src": "icon-192.png",
Expand Down
12 changes: 12 additions & 0 deletions src/components/Footer/Footer.style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ export const FooterSection = styled.section`
flex-basis: auto;
text-align: center;
}
a {
color: #FFF;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use colors from theme

}
a:hover {
color: #FFF;
}
a:active {
color: #FFF;
}
p {
margin-top: 0;
Expand Down
10 changes: 5 additions & 5 deletions src/components/Footer/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,26 @@ import dayjs from 'dayjs';
export const Footer = () => {
return (
<FooterWrapper>
<FooterLogo src={logo} alt="footer logo" />
<FooterLogo src={logo} alt="КПІ ім. Ігоря Сікорського" />
<FooterSection>
<p>
Національний технічний університет України"Київський політехнічний інститут імені Ігоря Сікорського" © 1998-{dayjs().year()}
</p>
<p>
Адреса: Україна, 03056 м.Київ-56, проспект Перемоги, 37
Адреса: <a href="https://kpi.ua/location">Україна, 03056 м.Київ-56, проспект Перемоги, 37</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use target="_blank" for links that lead outside of site.

</p>
</FooterSection>
<FooterSection>
<p>
Розробник – Конструкторське бюро інформаційних систем
Розробник – <a href="https://kbis.kpi.ua">Конструкторське бюро інформаційних систем</a>
</p>
<p>
Створено в рамках проекту "Електронний кампус КПІ"
Створено в рамках проекту "<a href="https://ecampus.kpi.ua">Електронний кампус КПІ</a>"
</p>
</FooterSection>
<FooterSection>
<p>
Використання матеріалу сайту тільки з обов’язковим посиланням на schedule.kpi.ua
Використання матеріалу сайту тільки з обов’язковим посиланням на <a href="https://schedule.kpi.ua">schedule.kpi.ua</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to keep a link to a site itself?

</p>
</FooterSection>
</FooterWrapper>
Expand Down