Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(logger): expose logger.__buffer__={}, add tests #69

Merged
merged 1 commit into from
Mar 6, 2023
Merged

chore(logger): expose logger.__buffer__={}, add tests #69

merged 1 commit into from
Mar 6, 2023

Commits on Mar 6, 2023

  1. chore(logger): expose logger._buffer={}, add tests 

    This commit exposes the private buffers publicly
_buffer={events=[],metrics=[],tracking=[]} on the logger instance.

In `3.x` this was exposed on `$beaver` but was removed in later
versions.

Adding this allows us much greater flexibility in testing as well as
allows consuming libraries to assert that they sent the correct events
to the buffer for logging.

This change also allows us to add a lot more tests easily (code coverage
jumped to 73%).
    @jamischarles
    jamischarles committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    cc72c85 View commit details
    Browse the repository at this point in the history