implement Docker API v1.41.1

[mavogel]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

• make all properties consistent (description (see feat/doc generation #193 ) etc.)
• be consistent with API v1.41.1
• keep https://docs.docker.com/engine/api/v1.41/ isn't implemented, so you can't pass cap_add to a service #34 and Support runtime parameter for docker_container #85 in mind

New or Affected Resource(s)

• docker_*

References

• refactor: do full internal refactoring  #94
• https://docs.docker.com/engine/api/v1.41/ isn't implemented, so you can't pass cap_add to a service #34

[suzuki-shunsuke]

Please let me confirm what to do.

• make all properties consistent (description etc.)

Does this mean to update field description in document and schema description in code according to the API document?

terraform-provider-docker/internal/provider/resource_docker_container.go

Line 247 in 6b0f977

Description: "List of string values to customize labels for MLS systems, such as SELinux. See https://docs.docker.com/engine/reference/run/#security-configuration",

• be consistent with API v1.41.1

Does this mean to upgrade Go Module of Docker API or to support additional resources?

[mavogel]

Does this mean to update field description in document and schema description in code according to the API document?

Yes and also. add missing properties of the API, which are not reflected yet in the schema.

Does this mean to upgrade Go Module of Docker API or to support additional resources?

IMHO we're already using the latest version since #119

[mavogel]

Related to #185

[tomalok]

I was thinking about this recently -- perhaps it's possible to generate the terraform schema directly from the official docker API definition?

[mavogel]

That's a very good point. Any idea/tools in mind @tomalok how to achieve this?

[tomalok]

I did a cursory search and found https://github.com/dikhan/terraform-provider-openapi which might be a good starting point / reference -- there may be others out there.

Obviously Docker's swagger is a lot bigger than the examples...

[github-actions]

This issue is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this issue to be closed, please set the label pinned.

[matifali]

are runtime arguments supported now?

[YurNaybor]

Sorry for digging out an old ticket, but is it now possible to configure capabilities for a service? I can't find it in the docs and trying to add

      capabilities {
        drop = ["ALL"]
        add = ["CAP_CHOWN", "CAP_FOWNER"]
      }

to docker_service -> task_spec -> container_spec yields an error in provider version 3.0.2 "Blocks of type "capabilities" are not expected here."

[dhilgarth]

@mavogel : Has this ever been implemented?

[chrisclayson]

Am exceptionally interested in this as require the cap_add functionality for Swarm services (#34) ... whilst this issue was closed as completed, the requirement from #34 doesn't seem to have been included ... is there any roadmap for this? Currently, finding myself needing manually provision a service that requires specific capabilities 😞