Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/doc generation #193

Merged
merged 64 commits into from
May 21, 2021
Merged

feat/doc generation #193

merged 64 commits into from
May 21, 2021

Conversation

mavogel
Copy link
Contributor

@mavogel mavogel commented May 13, 2021

Details

TODOs

  • add all descriptions for the attributes
  • how many attributes are required for datasources?
  • customize all templates to make descriptions more concise
  • read through all docs if they make sense and are understandable

Questions:

  • do we still need the link check for markdown? -> fixed rules in fb33652

@mavogel mavogel linked an issue May 13, 2021 that may be closed by this pull request
@mavogel mavogel added the documentation Improvements or additions to documentation label May 13, 2021
@mavogel mavogel added this to the v3.0.0 milestone May 13, 2021
@mavogel mavogel marked this pull request as ready for review May 21, 2021 07:28
@mavogel mavogel requested a review from suzuki-shunsuke May 21, 2021 07:28
Copy link
Collaborator

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about running make website-generation and checking if there is any change in CI?

@suzuki-shunsuke
Copy link
Collaborator

Thank you for your great work ❤️

mavogel added 2 commits May 21, 2021 13:52
to see if files changed and it should run locally again
from website lint because it's installed by default
@mavogel
Copy link
Contributor Author

mavogel commented May 21, 2021

@suzuki-shunsuke thanks for the hint. Added it! Take a look at the latest build/action

@suzuki-shunsuke suzuki-shunsuke self-requested a review May 21, 2021 12:30
@suzuki-shunsuke suzuki-shunsuke merged commit 6c796e1 into master May 21, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the feat/doc-generation branch May 21, 2021 12:30
@mavogel mavogel modified the milestones: v3.0.0, v2.12.0 May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add documentation generation
2 participants