chore: bump docker dependency to v20.10.5 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavogel
force-pushed
the
chore-bump-docker-dep
branch
from
4b197f2 to
32c7ad6
Compare
mavogel
force-pushed
the
chore-bump-docker-dep
branch
from
32c7ad6 to
9502029
Compare
mavogel
changed the title
| @@ -454,9 +444,6 @@ the extra mount mappings for the container. Each `configs` is a reference to a s | |||
| * `limits` - (Optional, list of strings) Describes the resources which can be advertised by a node and requested by a task. | |||
| * `nano_cpus` (Optional, int) CPU shares in units of 1/1e9 (or 10^-9) of the CPU. Should be at least 1000000 | |||
| * `memory_bytes` (Optional, int) The amount of memory in bytes the container allocates | |||
| * `generic_resources` (Optional, map) User-defined resources can be either Integer resources (e.g, SSD=3) or String resources (e.g, GPU=UUID1) | |||
| * `named_resources_spec` (Optional, set of string) The String resources, delimited by `=` | |||
| * `discrete_resources_spec` (Optional, set of string) The Integer resources, delimited by `=` | |||
There was a problem hiding this comment.
This PR includes breaking changes, right?
If so, we should update the major version according to the semver.
There was a problem hiding this comment.
Yes, it will include BCs and I guess #102 as well. So we will bump a major.
There was a problem hiding this comment.
📝 I don't know the feature generic_resources well. I'll investigate later.
- https://docs.docker.com/engine/reference/commandline/service_create/#create-services-requesting-generic-resources
- https://pkg.go.dev/github.com/docker/docker@v20.10.5+incompatible/api/types/swarm#GenericResource
- https://pkg.go.dev/github.com/docker/docker@v20.10.5+incompatible/api/types/swarm#ResourceRequirements
suzuki-shunsuke
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #102 we need to update dependencies due to broken windows build. So we split this out
Steps