Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The score is always 1 when using extendedSearch and "include" match type #522

Closed
baibonjwa opened this issue Dec 14, 2020 · 1 comment · Fixed by #525 · May be fixed by usernamerandom11/JokeAPI#38 or usernamerandom11/JokeAPI#39
Closed

The score is always 1 when using extendedSearch and "include" match type #522

baibonjwa opened this issue Dec 14, 2020 · 1 comment · Fixed by #525 · May be fixed by usernamerandom11/JokeAPI#38 or usernamerandom11/JokeAPI#39
Labels
bug

Comments

@baibonjwa
Copy link

baibonjwa commented Dec 14, 2020 •
edited
Loading

Describe the bug

image

The score is always 1 and I cannot sort the results. Is this a bug or expected behavior?

Version

6.4.3

Minimal Reproduction

Demo: https://jsfiddle.net/baibonjwa/dcoL1nth/17/
@baibonjwa baibonjwa added the bug label Dec 14, 2020
@skearney6
Copy link
Contributor

Yes! This one was messing me up big time. I see that the scoring for this looks flipped in the code. I'm going to send a PR for that - hopefully it will be accepted quickly. 🤞

skearney6 added a commit to skearney6/Fuse that referenced this issue Dec 23, 2020
@skearney6
fix(extended): correctly score include-match results
49997dc 
change score to 0/1 when matched/not matched, respectively

fixes krisk#522
@skearney6 skearney6 mentioned this issue Dec 23, 2020
Merged
krisk pushed a commit that referenced this issue Dec 29, 2020
@skearney6 @krisk
fix(extended): correctly score include-match results
443c863 
change score to 0/1 when matched/not matched, respectively

fixes #522
@usernamerandom11 usernamerandom11 mentioned this issue Sep 7, 2024
Open
@usernamerandom11 usernamerandom11 mentioned this issue Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@baibonjwa @skearney6