fix(extended): correctly score include-match results

change score to 0/1 when matched/not matched, respectively fixes krisk#522
skearney6 · Dec 23, 2020 · 49997dc · 49997dc
1 parent 33be0ac
commit 49997dc
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 40 deletions.
diff --git a/dist/fuse.common.js b/dist/fuse.common.js
@@ -1499,7 +1499,7 @@ var IncludeMatch = /*#__PURE__*/function (_BaseMatch) {
       var isMatch = !!indices.length;
       return {
         isMatch: isMatch,
-        score: isMatch ? 1 : 0,
+        score: isMatch ? 0 : 1,
         indices: indices
       };
     }

diff --git a/dist/fuse.esm.js b/dist/fuse.esm.js
@@ -1125,7 +1125,7 @@ class IncludeMatch extends BaseMatch {
 
     return {
       isMatch,
-      score: isMatch ? 1 : 0,
+      score: isMatch ? 0 : 1,
       indices
     }
   }

diff --git a/dist/fuse.esm.min.js b/dist/fuse.esm.min.js
diff --git a/dist/fuse.js b/dist/fuse.js
@@ -1503,7 +1503,7 @@
         var isMatch = !!indices.length;
         return {
           isMatch: isMatch,
-          score: isMatch ? 1 : 0,
+          score: isMatch ? 0 : 1,
           indices: indices
         };
       }

diff --git a/dist/fuse.min.js b/dist/fuse.min.js
diff --git a/src/search/extended/IncludeMatch.js b/src/search/extended/IncludeMatch.js
@@ -1,5 +1,5 @@
 // Token: 'file
-// Match type: exact-match
+// Match type: include-match
 // Description: Items that include `file`
 
 import BaseMatch from './BaseMatch'
@@ -34,7 +34,7 @@ export default class IncludeMatch extends BaseMatch {
 
     return {
       isMatch,
-      score: isMatch ? 1 : 0,
+      score: isMatch ? 0 : 1,
       indices
     }
   }

diff --git a/test/__snapshots__/extended-search.test.js.snap b/test/__snapshots__/extended-search.test.js.snap
@@ -140,7 +140,7 @@ Array [
       },
     ],
     "refIndex": 0,
-    "score": 1,
+    "score": 8.569061098350962e-12,
   },
   Object {
     "item": Object {
@@ -159,7 +159,7 @@ Array [
       },
     ],
     "refIndex": 2,
-    "score": 1,
+    "score": 1.4901161193847656e-8,
   },
 ]
 `;
@@ -468,45 +468,45 @@ exports[`Searching using extended search Search: literal match with fuzzy match
 Array [
   Object {
     "item": Object {
-      "text": "hello word",
+      "text": "indeed fine hello foo",
     },
     "matches": Array [
       Object {
         "indices": Array [
           Array [
             0,
-            4,
+            10,
+          ],
+          Array [
+            18,
+            20,
           ],
         ],
         "key": "text",
-        "value": "hello word",
+        "value": "indeed fine hello foo",
       },
     ],
-    "refIndex": 0,
-    "score": 0.3205001277290518,
+    "refIndex": 2,
+    "score": 1.4901161193847656e-8,
   },
   Object {
     "item": Object {
-      "text": "indeed fine hello foo",
+      "text": "hello word",
     },
     "matches": Array [
       Object {
         "indices": Array [
           Array [
             0,
-            10,
-          ],
-          Array [
-            18,
-            20,
+            4,
           ],
         ],
         "key": "text",
-        "value": "indeed fine hello foo",
+        "value": "hello word",
       },
     ],
-    "refIndex": 2,
-    "score": 0.7071067811865476,
+    "refIndex": 0,
+    "score": 0.3205001277290518,
   },
 ]
 `;
@@ -515,45 +515,45 @@ exports[`Searching using extended search Search: literal match with regular matc
 Array [
   Object {
     "item": Object {
-      "text": "indeed fine hello foo",
+      "text": "how are you",
     },
     "matches": Array [
       Object {
         "indices": Array [
           Array [
-            0,
-            10,
-          ],
-          Array [
-            18,
-            20,
+            4,
+            6,
           ],
         ],
         "key": "text",
-        "value": "indeed fine hello foo",
+        "value": "how are you",
       },
     ],
-    "refIndex": 2,
-    "score": 0.7071067811865476,
+    "refIndex": 1,
+    "score": 9.287439764962262e-10,
   },
   Object {
     "item": Object {
-      "text": "how are you",
+      "text": "indeed fine hello foo",
     },
     "matches": Array [
       Object {
         "indices": Array [
           Array [
-            4,
-            6,
+            0,
+            10,
+          ],
+          Array [
+            18,
+            20,
           ],
         ],
         "key": "text",
-        "value": "how are you",
+        "value": "indeed fine hello foo",
       },
     ],
-    "refIndex": 1,
-    "score": 1,
+    "refIndex": 2,
+    "score": 1.4901161193847656e-8,
   },
 ]
 `;
@@ -601,7 +601,7 @@ Array [
       },
     ],
     "refIndex": 2,
-    "score": 1,
+    "score": 1.4901161193847656e-8,
   },
 ]
 `;