-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release V2 as stable #173
Open
hthetiot
wants to merge
70
commits into
v1
Choose a base branch
from
v2
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
release V2 as stable #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hthetiot
commented
Jul 20, 2018
•
edited
Loading
edited
- need to remove collections from v2 like v1 did
All specs pass. Implemented `Readable` as an abstract interface that provides `forEach`, `map`, `reduce`, `buffer`, `all`, `copy`, and `read` for any implementation that provides the asynchronous iterator method, `next`. Readable makes use of a semaphore `Queue` and a `Pipe` to control back-pressure based on user-given or methd-specific-default parallelism limits. Implemented a `Reader` stream that wraps an array or any object, local or remote, that provides a `next` method, including iterators and generator iterators. Thus, a stream can lazily consume an indefinite iteration. Brought in a cleaner implementation of the indefinite promise `Queue`. This implementation lacks the `close` and `closed` hacks that exist in the current `q/queue`, which will likely be removed when these changes get traction, particularly in Q-Connection. Implemented a `BufferStream`, backed by a `Queue`, that provides both `Reader` and `Writer` interfaces, as well as an acknoweldgement channel. `put` returns a promise for when `get` has been consumed. The Node.js stream reader has been reimplemented based on the latest rendition of Node.js streams and the new `StreamBuffer`, so promise streams send back pressure down to the underlying system. Cosmetic changes only to `Writer`. Created a separate mock file stream, which manages an internal `chunks` array which can be reused on mock file system nodes between reads and writes. This turned out to be different enough from `Reader` and `BufferStream` that a different implementation was needed. The old `BufferStream`, originally used by the mock file system has gone away. Special cases in the HTTP server have been removed, leaving a clean interface that handles all cases including new streams for bodies. Ported `WebStream`, by factoring the stream adapter in Q-Connection together with the new `BufferStream`. The new streams model connection closing much more elegantly. `WebStream` is idempotent and can wrap `MessageChannel` ports, `WebWorker`, and `WebSocket`. Q-Connection will eventually be refactored to take advantage of `WebStream`. Created `WindowStream`, using code contributed to Q-Connection by @johnjdalton two years ago. Window streams are useful for establishing bidirectional connections between windows and frames. WindowStream is not a constructor, but has `listen` and `connect` methods. `listen` returns a stream of streams, which can be closed to shut down. `connect` returns a stream that will buffer and pipe messages when and if the connection is established.
Rename followInsecureSymlinks to followInsecureSymbolicLinks. This now matches what is writhe in the readme and release notes.
Rename followInsecureSymlinks to followInsecureSymbolicLinks. This now matches what is writhe in the readme and release notes.
Conflicts: CHANGES.md http-apps/fs.js package.json
Because they are tests. Not specifications.
Don't implicitly reroot to the base of the prefix path.
Not for the faint of heart.
Fix URL2 dependency
Synchronize versions
Node.js 0.11 checks whether to use an agent based on whether the agent property exists, not whether the agent property is truthy.
Continued refinement of request normalization and fixed cookie handling.
…dav.org test.webdav.org:80
Fix up tests on v2 branch
kriskowal
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.