Add changes to fetch Accelerator metrics at the time of recommendation generation #1319
Conversation
Signed-off-by: bharathappali <abharath@redhat.com>
…n generation Signed-off-by: bharathappali <abharath@redhat.com>
bharathappali
force-pushed
the
gpu-support-pr-5
branch
from
4f186c4
to
39f797e
Compare
| @@ -315,4 +335,164 @@ public static boolean isInvalidDataSource(DataSourceInfo datasource) { | |||
| return datasource == null || datasource.getAuthenticationConfig() == null || | |||
| datasource.getAuthenticationConfig().toString().isEmpty(); | |||
| } | |||
|
|
|||
| public static void markAcceleratorDeviceStatusToContainer (ContainerData containerData, | |||
There was a problem hiding this comment.
What is the reasoning for adding this to autotune/common/utils? In general, I would try to limit of scope of use for a method to only those that need it and not make too broad
There was a problem hiding this comment.
I thought to use it in services to check if there is GPU attached at the time of experiment creation so I have added it to common utils. Later the design is changed so I thought it's better to leave it in common so that sometime we might use it across the project to check for GPU usage and mark the containers.
There was a problem hiding this comment.
Lets increase the scope of the method when it is actually needed, I'd prefer to keep it local for now
There was a problem hiding this comment.
Sure, Can I move it to RecommendationUtils?
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Description
This PR is fifth part of the set of PR's which will be raised for adding GPU support #1312
This PR adds changes to fetch Accelerator metrics at the time of recommendation generation
This PR is build on top of #1318, so it needs to be merged after merging #1318
Fixes #1312
Type of change
How has this been tested?
Tests are added in a different PR
Test Configuration
Checklist 🎯
Additional information
None