-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds changes to RecommendationItem enum to accomodate MIG strings #1318
Conversation
@bharathappali Needs to be rebased against mvp_demo |
Apologies for the overlook, I have rebased to |
@bharathappali Please rebase as I've merged your earlier PRs |
Signed-off-by: bharathappali <abharath@redhat.com>
4184bcc
to
802183c
Compare
Sure, I have rebased to latest mvp_demo @dinogun . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bharathappali The crc PR check is failing. Looks like some tests need to be updated with the new CONSTANTS |
@dinogun Yes we need the adapter for the recommendation item enum, as the changes are getting lengthy I have added them in subsequent PR's |
@dinogun As there is no adapter the keys in recommendation are changed in this way
This will be fixed in #1321 |
Merging with the assumption that PR #1321 will fix the test failures |
Description
This PR is fourth part of the set of PR's which will be raised for adding GPU support #1312
This PR adds changes to RecommendationItem enum to accomodate MIG strings
This PR is build on top of #1317, so it needs to be merged after merging #1317
Fixes #1312
Type of change
How has this been tested?
Tests will be added in the subsequent PR
Test Configuration
Checklist 🎯
Additional information
None