Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds changes to RecommendationItem enum to accomodate MIG strings #1318

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

bharathappali
Copy link
Member

Description

This PR is fourth part of the set of PR's which will be raised for adding GPU support #1312

This PR adds changes to RecommendationItem enum to accomodate MIG strings

This PR is build on top of #1317, so it needs to be merged after merging #1317

Fixes #1312

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Tests will be added in the subsequent PR

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

None

@dinogun
Copy link
Contributor

dinogun commented Oct 4, 2024

@bharathappali Needs to be rebased against mvp_demo

@bharathappali bharathappali changed the base branch from master to mvp_demo October 4, 2024 12:14
@bharathappali
Copy link
Member Author

Apologies for the overlook, I have rebased to mvp_demo. Thanks @dinogun

@dinogun
Copy link
Contributor

dinogun commented Oct 4, 2024

@bharathappali Please rebase as I've merged your earlier PRs

Signed-off-by: bharathappali <abharath@redhat.com>
@bharathappali
Copy link
Member Author

Sure, I have rebased to latest mvp_demo @dinogun .

Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun
Copy link
Contributor

dinogun commented Oct 7, 2024

@bharathappali The crc PR check is failing. Looks like some tests need to be updated with the new CONSTANTS

@bharathappali
Copy link
Member Author

@dinogun Yes we need the adapter for the recommendation item enum, as the changes are getting lengthy I have added them in subsequent PR's

@bharathappali
Copy link
Member Author

@dinogun As there is no adapter the keys in recommendation are changed in this way

"variation": {
                            "requests": {
                              "MEMORY": {
                                "amount": 187.98999999999998,
                                "format": "MiB"
                              },
                              "CPU": {
                                "amount": -0.17000000000000015,
                                "format": "cores"
                              }
                            },
                            "limits": {
                              "MEMORY": {
                                "amount": 138.2,
                                "format": "MiB"
                              },
                              "CPU": {
                                "amount": 0.42999999999999994,
                                "format": "cores"
                              }
                            }
                          },

This will be fixed in #1321

@dinogun
Copy link
Contributor

dinogun commented Oct 7, 2024

Merging with the assumption that PR #1321 will fix the test failures

@dinogun dinogun merged commit 7d024ef into kruize:mvp_demo Oct 7, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GPU MIG Right sizing recommendations by kruize
2 participants