-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapter for DeviceDetails #1324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to be rebased against mvp_demo |
Apologies for the overlook, I have rebased to |
bharathappali
force-pushed
the
gpu-support-pr-8
branch
from
October 7, 2024 10:26
a616a23
to
c201c28
Compare
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
bharathappali
force-pushed
the
gpu-support-pr-8
branch
from
October 8, 2024 07:49
c201c28
to
ff1873c
Compare
dinogun
reviewed
Oct 8, 2024
dinogun
reviewed
Oct 8, 2024
src/main/java/com/autotune/analyzer/adapters/RecommendationItemAdapter.java
Show resolved
Hide resolved
12 tasks
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
dinogun
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is eighth part of the set of PR's which will be raised for adding GPU support #1312
This PR adds adapter for DeviceDetails to serialize and deserialize the class
This PR is build on top of #1321, so it needs to be merged after merging #1321
Fixes #1312
Type of change
How has this been tested?
Tests will be added in the other PR
Test Configuration
Checklist 🎯
Additional information
None